Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the displayed value using ".innerHtml =" throws an error #169

Closed
jason-capsule42 opened this issue Jan 26, 2024 · 0 comments · Fixed by #170
Closed

Setting the displayed value using ".innerHtml =" throws an error #169

jason-capsule42 opened this issue Jan 26, 2024 · 0 comments · Fixed by #170
Assignees
@jason-capsule42
Labels
auro-select Type: Bug Bug or Bug fixes

Comments

@jason-capsule42
Copy link
Member

jason-capsule42 commented Jan 26, 2024 •
edited
Loading

Describe the bug

Setting the displayed value using ".innerHtml =" throws an error

To Reproduce

Steps to reproduce the behavior:

  1. Run the local host
  2. Go to the API page
  3. Look in the console

See this error:

Error: This ChildParthas noparentNodeand therefore cannot accept a value. This likely means the element containing the part was manipulated in an unsupported way outside of Lit's control such that the part's marker nodes were ejected from DOM. For example, setting the element'sinnerHTMLortextContent can do this.

Expected behavior

No errors

Switching from setting innerHtml to createNode will solve this.
@jason-capsule42 jason-capsule42 added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-select labels Jan 26, 2024
@jason-capsule42 jason-capsule42 self-assigned this Jan 26, 2024
jason-capsule42 added a commit that referenced this issue Jan 26, 2024
@jason-capsule42
fix(value): remove usage of innerHtml and use createNode instead #169
a3a0c55
jason-capsule42 added a commit that referenced this issue Jan 26, 2024
@jason-capsule42
fix(value): remove usage of innerHtml and use createNode instead #169
ca2a1a5
jason-capsule42 added a commit that referenced this issue Jan 26, 2024
@jason-capsule42
fix(value): remove usage of innerHtml and use createNode instead #169
1f837f5
blackfalcon pushed a commit that referenced this issue Jan 26, 2024
@jason-capsule42 @blackfalcon
fix(value): remove usage of innerHtml and use createNode instead #169
ddeedf8
blackfalcon pushed a commit that referenced this issue Jan 26, 2024
@semantic-release-bot
chore(release): 2.9.0 [skip ci]
c606d42 
# [2.9.0](v2.8.5...v2.9.0) (2024-01-26)

### Bug Fixes

* **value:** remove usage of innerHtml and use createNode instead [#169](#169) ([ddeedf8](ddeedf8))

### Features

* **deps:** update dependencies and add SSR support [#166](#166) [#167](#167) ([38f02a8](38f02a8))

### Performance Improvements

* update static style template for lit ([d2e3058](d2e3058))
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Jan 28, 2024
@blackfalcon blackfalcon linked a pull request Jan 28, 2024 that will close this issue
remove usage of innerHtml and use createNode instead #170
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jason-capsule42 jason-capsule42

Labels
auro-select Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove usage of innerHtml and use createNode instead AlaskaAirlines/auro-select
4 participants
@blackfalcon @jason-capsule42 @Patrick-Daly-AA @pgm369