Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete example for value #89

Closed
jordanjones243 opened this issue Aug 17, 2022 · 0 comments · Fixed by #90
Closed

Incomplete example for value #89

jordanjones243 opened this issue Aug 17, 2022 · 0 comments · Fixed by #90
Assignees
@jordanjones243
Labels
auro-select Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Milestone
auro-select v2.5-...

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Aug 17, 2022 •
edited
Loading

Describe the bug

There is no example present in the demo for programmatically setting an invalid value or resetting a value in select.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/select/api.
  2. Scroll to value example.
  3. See that it only shows preset value.

Expected behavior

Should also show changing value programmatically to either:

  1. Valid value
  2. Invalid value
  3. Undefined
@jordanjones243 jordanjones243 added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-select labels Aug 17, 2022
@jordanjones243 jordanjones243 self-assigned this Aug 17, 2022
@jordanjones243 jordanjones243 changed the title No example for reset value Incomplete example for value Aug 24, 2022
jordanjones243 added a commit that referenced this issue Aug 24, 2022
@jordanjones243
fix(example): add additional functionality to value example #89
d2fb351
jordanjones243 added a commit that referenced this issue Aug 24, 2022
@jordanjones243
test(example): add tests for updated value example #89
3e35e56
@jordanjones243 jordanjones243 mentioned this issue Aug 24, 2022
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 24, 2022 that will close this issue
Add addtional functionality to value example #90
Merged
6 tasks
@blackfalcon blackfalcon added the Status: Work In Progress Issue or Pull Request work is in Progress label Aug 25, 2022
jason-capsule42 pushed a commit that referenced this issue Sep 2, 2022
@jordanjones243 @jason-capsule42
fix(example): add additional functionality to value example #89
594ed81
jason-capsule42 pushed a commit that referenced this issue Sep 2, 2022
@jordanjones243 @jason-capsule42
test(example): add tests for updated value example #89
fd44493
jason-capsule42 pushed a commit that referenced this issue Sep 2, 2022
@jordanjones243 @jason-capsule42
fix(example): add additional functionality to value example #89
af82cee
jason-capsule42 pushed a commit that referenced this issue Sep 2, 2022
@jordanjones243 @jason-capsule42
test(example): add tests for updated value example #89
7b3e4f3
jason-capsule42 pushed a commit that referenced this issue Sep 2, 2022
@jordanjones243 @jason-capsule42
fix(example): add additional functionality to value example #89
3d72fe0
jason-capsule42 pushed a commit that referenced this issue Sep 2, 2022
@jordanjones243 @jason-capsule42
test(example): add tests for updated value example #89
ed25f99
blackfalcon pushed a commit that referenced this issue Sep 2, 2022
@semantic-release-bot
chore(release): 2.4.2 [skip ci]
15f7b7d 
## [2.4.2](v2.4.1...v2.4.2) (2022-09-02)

### Bug Fixes

* **example:** add additional functionality to value example [#89](#89) ([3d72fe0](3d72fe0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-select Status: Work In Progress Issue or Pull Request work is in Progress Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
auro-select v2.5-rc (flight search)
Development

Successfully merging a pull request may close this issue.

Add addtional functionality to value example AlaskaAirlines/auro-select
2 participants
@blackfalcon @jordanjones243