Fix dropdown positioning issue inside auro-dialog #190
Conversation
- This commit addresses the positioning issue of `auro-dropdown` when `auro-select` is placed inside `auro-dialog` component Changes to be committed: modified: package-lock.json modified: src/auro-select.js modified: src/style.scss
Changes to be committed: modified: package-lock.json modified: package.json
blackfalcon
force-pushed
the
fajarapri/fixPositioning
branch
from
ea0591a to
4b43b22
Compare
This commit updates the pakcage.json build scripts to be compliant with the decisions made in this discussion: https://github.com/orgs/AlaskaAirlines/discussions/523 Changes to be committed: modified: .github/workflows/testPublish.yml modified: package.json
There was a problem hiding this comment.
I'm struggling to validate that this fix is actually correct.
I am unable to setup a working example that is broken without the style changes and works correctly with them.
The change should include some sort of example that demonstrates this now works. If you add an example to the docpage then we should be able to run this locally and simply comment out the style changes and see it broken.
@jason-capsule42, Is it really needed to put the example in the docsite? To be honest, I was also struggling to replicate the issue in the docsite, |
|
🎉 This PR is included in version 2.10.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #187
Summary:
auro-dropdownwhenauro-selectis placed insideauro-dialogcomponent.Please see below videos for related fixes:
Screen.Recording.2024-05-30.at.11.48.46.mov
Also, the fixes seems to not creating any regression when implemented on its own in the docsite:
Screen.Recording.2024-05-30.at.14.21.10.mov
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team