Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): add ready state checks and all automated tests #38 #75 #80

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

jason-capsule42
Copy link
Member

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes: #38, #75

Summary:

Adds the ready check behavior for peer dependencies and all automated testing to pass threshold requirements.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred that the different updates were kept in individual commits, e.g. tests versus features.

Other than that, please update the JSDoc comments are you are good to go.

src/auro-select.js Outdated Show resolved Hide resolved
src/auro-select.js Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 97169e9 into main Aug 3, 2022
@jason-capsule42 jason-capsule42 deleted the jbaker/testingUpdates branch August 3, 2022 18:33
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize the new ready states from dependencies Update tests to fully support 80% coverage
3 participants