Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component registration logic #92

Closed
sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #93
Closed

Update component registration logic #92

sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #93
Assignees
@sun-mota
Labels
auro-table not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@sun-mota
Copy link
Contributor

Please verify the version of auro-table you have installed

No response

Please describe the bug

Default import of index.js should register the default custom element only.

import of the component class should not register the custom element at all.

Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response
@sun-mota sun-mota added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members auro-table labels Oct 17, 2024
@sun-mota sun-mota self-assigned this Oct 17, 2024
@sun-mota sun-mota mentioned this issue Oct 21, 2024
Merged
6 tasks
@sun-mota sun-mota linked a pull request Oct 21, 2024 that will close this issue
feat(api): add register static method #93
Merged
6 tasks
sun-mota added a commit that referenced this issue Oct 21, 2024
@sun-mota
feat(api): add register static method #92
73bc4fa 
`AuroTable.register` is to easily register the element without extra importing
`import "@aurodesignsystem/auro-table"` will still register this element to <auro-table>
`import { AuroTable } from '../src/auro-table.js` wont register this element until `AuroTable.register` gets called

Fixed the typo on Recommended Use and Version Control.
`clement` -> `element`
sun-mota added a commit that referenced this issue Oct 21, 2024
@sun-mota
feat(api): add register static method #92
96d0069 
`AuroTable.register` is to easily register the element without extra importing
`import "@aurodesignsystem/auro-table"` will still register this element to <auro-table>
`import { AuroTable } from '../src/auro-table.js` wont register this element until `AuroTable.register` gets called

Fixed the typo on Recommended Use and Version Control.
`clement` -> `element`
blackfalcon pushed a commit that referenced this issue Oct 21, 2024
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
cf3ae3e 
# [3.1.0](v3.0.1...v3.1.0) (2024-10-21)

### Features

* **api:** add register static method [#92](#92) ([96d0069](96d0069))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sun-mota sun-mota

Labels
auro-table not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): add register static method AlaskaAirlines/auro-table
2 participants
@sun-mota @Patrick-Daly-AA