perf: check for headers before generating rows

[jason-capsule42]

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

• New capability
• Revision of an existing capability
• Infrastructure change (automation, etc.)
• Other (please elaborate)

Checklist:

• My update follows the CONTRIBUTING guidelines of this project
• I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Enhancements:

• Add a check to ensure 'componentData' and 'columnHeaders' are present before generating table rows.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR adds a defensive check in the table row generation logic to ensure both componentData and columnHeaders are available before attempting to generate table rows. This prevents potential errors from occurring when the data or headers are undefined.

Updated class diagram for AuroTable

classDiagram
    class AuroTable {
        +LitElement
        +componentData
        +columnHeaders
        +extractRows()
    }
    note for AuroTable "Added checks for componentData and columnHeaders before generating rows"

Loading

File-Level Changes

Change	Details	Files
Added null checks before table row generation	Wrapped row generation logic in a conditional check for componentData and columnHeaders Maintained existing row and cell creation logic within the safeguard	src/auro-table.js

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @jason-capsule42 - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

• Consider using textContent instead of innerHTML to prevent potential XSS vulnerabilities (link)

Overall Comments:

• Consider adding error logging or warning when componentData or columnHeaders are undefined/null rather than silently failing

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🔴 Security: 1 blocking issue
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[blackfalcon]

🎉 This PR is included in version 3.1.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀