Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic color token names #38

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Mar 15, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #37

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Replace tier 1 tokens with newly created tier 3 tokens
  • Replace semantically incorrect tier 2 tokens with correct tier 2 tokens

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • Make sure UI layout and colors are correct
  • Ensure tier 3 tokens are appropriately named
  • Verify tier 3 tokens and rules are all pointing to correct tier 2 tokens

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Mar 15, 2024
@jordanjones243 jordanjones243 linked an issue Mar 15, 2024 that may be closed by this pull request
2 tasks
@jordanjones243 jordanjones243 force-pushed the jjones/updateColorTokens/#37 branch 2 times, most recently from 915c35a to 8f0f7aa Compare May 29, 2024 18:14
@jordanjones243 jordanjones243 force-pushed the jjones/updateColorTokens/#37 branch from a1ef6dd to 5d85f89 Compare June 5, 2024 18:04
@jordanjones243 jordanjones243 marked this pull request as ready for review June 5, 2024 18:05
@jordanjones243 jordanjones243 requested a review from a team as a code owner June 5, 2024 18:05
src/tokens.scss Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jjones/updateColorTokens/#37 branch from 5d85f89 to 307db52 Compare June 19, 2024 00:03
@blackfalcon blackfalcon force-pushed the jjones/updateColorTokens/#37 branch from 307db52 to 965820f Compare June 22, 2024 02:43
@jordanjones243 jordanjones243 changed the base branch from main to beta June 25, 2024 21:59
src/tokens.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
src/color.scss Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the jjones/updateColorTokens/#37 branch from 92d914f to 5a55ed9 Compare July 9, 2024 01:15
@jason-capsule42 jason-capsule42 force-pushed the jjones/updateColorTokens/#37 branch from 27b3379 to 629384c Compare July 9, 2024 01:25
@jason-capsule42 jason-capsule42 requested review from blackfalcon and removed request for blackfalcon July 9, 2024 01:25
@jason-capsule42 jason-capsule42 dismissed blackfalcon’s stale review July 9, 2024 01:26

Comments addressed

@jason-capsule42 jason-capsule42 merged commit 73d0e06 into beta Jul 9, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/updateColorTokens/#37 branch July 9, 2024 01:28
@blackfalcon
Copy link
Member

🎉 This PR is included in version 1.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
3 participants