-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add register static method #50
Conversation
Reviewer's Guide by SourceryThis pull request adds a new static Class diagram for AuroToast with new register methodclassDiagram
class AuroToast {
+static register(name="auro-toast")
+firstUpdated()
}
note for AuroToast "Added static register method to simplify element registration"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
e78ccc2
to
f5bee45
Compare
`AuroToast.register` is to easily register the element without extra importing `import "@aurodesignsystem/auro-toast"` will still register this element to <auro-toast> `import { AuroToast } from '../src/auro-toast.js` wont register this element until `AuroToast.register` gets called Fixed the typo on Recommended Use and Version Control. `clement` -> `element`
f5bee45
to
d1e0b11
Compare
5b4bd2e
to
aa480d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After running a build there are 4 files with changes that aren't checked into this PR.
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixed the typo on Recommended Use and Version Control.
clement
->element
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #49
Summary:
AuroToast.register
is to easily register the element without extra importingimport "@aurodesignsystem/auro-toast"
will still register this element toimport { AuroToast } from '../src/auro-toast.js
wont register this element untilAuroToast.register
gets calledType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add a static method
AuroToast.register
to facilitate the registration of theauro-toast
element with a custom name, and update documentation to reflect this change. Remove the default element registration to encourage the use of the new method.New Features:
AuroToast.register
to allow dynamic registration of the custom element with a specified name.Enhancements:
auro-toast
element to rely on the newregister
method for element registration.Documentation:
AuroToast.register
method for registering custom elements.