Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fully customized toasts #53 #55

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Nov 6, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Add support for fully customized toast notifications, enabling custom SVG icons, color customization, and the ability to disable auto-hide. Update documentation to reflect these new customization options.

New Features:

  • Introduce support for fully customized toast notifications, allowing users to pass custom SVGs, recolor notifications, and disable auto-hide behavior.

Enhancements:

  • Refactor toast component to handle custom SVG icons and improve the handling of toast visibility and auto-hide functionality.

Documentation:

  • Update documentation to include instructions on customizing toast notifications, including using custom SVGs, recoloring, and disabling auto-hide.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner November 6, 2024 07:31
Copy link

sourcery-ai bot commented Nov 6, 2024

Reviewer's Guide by Sourcery

This PR adds support for fully customizable toast notifications by introducing new features like custom SVG icons, color customization, and the ability to disable auto-hide behavior. The implementation modifies the core toast component to handle these new customization options and updates the documentation accordingly.

Updated class diagram for AuroToast component

classDiagram
    class AuroToast {
        Boolean visible
        String variant
        Boolean noIcon
        Boolean disableAutoHide
        clickToClose()
        fadeOutToast()
        getVariantIcon() HTMLElement
        handleSlotContent() void
    }
    note for AuroToast "Added disableAutoHide attribute and methods for custom SVG handling"
Loading

File-Level Changes

Change Details Files
Added support for custom toast notifications with new customization options
  • Added disableAutoHide property to prevent auto-hiding of toasts
  • Added support for custom SVG icons through a new slot
  • Added variant='custom' support for custom styling
  • Added color customization through CSS custom properties
src/auro-toast.js
Refactored toast visibility and icon handling logic
  • Extracted variant icon logic into a separate getVariantIcon method
  • Added handleSlotContent method to handle custom SVG injection
  • Updated visibility handling to respect disableAutoHide setting
  • Renamed handleOnClose to clickToClose for better clarity
src/auro-toast.js
Added comprehensive documentation and examples for new features
  • Added new section for customizing toast notifications
  • Added example demonstrating custom SVG, colors, and auto-hide settings
  • Updated API documentation with new properties
  • Added new demo files for custom toast examples
demo/index.md
docs/partials/index.md
demo/api.md
docs/api.md
apiExamples/customToast.html
apiExamples/customToast.js

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There are console.warn() and console.error() statements that should be removed from production code in getVariantIcon() and handleSlotContent()
  • Please explain the reason for downgrading auro-library from 2.10.1 to ~2.8 in package.json
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/auro-toast.js Show resolved Hide resolved
demo/index.md Outdated Show resolved Hide resolved
src/auro-toast.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the jbaker/customizedToast branch 5 times, most recently from f62132a to bc779b4 Compare November 6, 2024 07:45
@jason-capsule42 jason-capsule42 self-assigned this Nov 6, 2024
@jason-capsule42
Copy link
Member Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/auro-toast.js Outdated Show resolved Hide resolved
src/auro-toast.js Outdated Show resolved Hide resolved
src/auro-toast.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the jbaker/customizedToast branch 2 times, most recently from d977ee8 to 38c1b28 Compare November 6, 2024 07:55
@jason-capsule42
Copy link
Member Author

@sourcery-ai review

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you explain the reason for downgrading auro-library from ^2.10.1 to ~2.8? This seems like a potentially risky change that needs justification.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

docs/api.md Outdated Show resolved Hide resolved
docs/api.md Show resolved Hide resolved
src/auro-toast.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
demo/api.min.js Show resolved Hide resolved
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a build:release causes the index.min.js and api.min.js causes the initExamples function export to be removed, therefore breaking the examples on the demo pages.

@jason-capsule42
Copy link
Member Author

Running a build:release causes the index.min.js and api.min.js causes the initExamples function export to be removed, therefore breaking the examples on the demo pages.

This has been resolved.

Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues:

X icon does not look vertically centered when the notification icon is present
Screen Shot 2024-11-08 at 9 01 11 AM

This error comes up when clicking the X button on new custom toast example
Screen Shot 2024-11-08 at 9 01 35 AM

@jason-capsule42 jason-capsule42 force-pushed the jbaker/customizedToast branch 2 times, most recently from 53736d1 to 5493074 Compare November 13, 2024 17:16
jordanjones243
jordanjones243 previously approved these changes Nov 13, 2024
jordanjones243
jordanjones243 previously approved these changes Nov 13, 2024
@jason-capsule42 jason-capsule42 merged commit 4d6f91a into main Nov 13, 2024
6 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/customizedToast branch November 13, 2024 20:02
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-toast: Flexibility to choose icon, background color, and not have it auto-dismiss
4 participants