-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support fully customized toasts #53 #55
Conversation
Reviewer's Guide by SourceryThis PR adds support for fully customizable toast notifications by introducing new features like custom SVG icons, color customization, and the ability to disable auto-hide behavior. The implementation modifies the core toast component to handle these new customization options and updates the documentation accordingly. Updated class diagram for AuroToast componentclassDiagram
class AuroToast {
Boolean visible
String variant
Boolean noIcon
Boolean disableAutoHide
clickToClose()
fadeOutToast()
getVariantIcon() HTMLElement
handleSlotContent() void
}
note for AuroToast "Added disableAutoHide attribute and methods for custom SVG handling"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- There are console.warn() and console.error() statements that should be removed from production code in getVariantIcon() and handleSlotContent()
- Please explain the reason for downgrading auro-library from 2.10.1 to ~2.8 in package.json
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
f62132a
to
bc779b4
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
d977ee8
to
38c1b28
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you explain the reason for downgrading auro-library from ^2.10.1 to ~2.8? This seems like a potentially risky change that needs justification.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
38c1b28
to
7345bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running a build:release
causes the index.min.js
and api.min.js
causes the initExamples
function export to be removed, therefore breaking the examples on the demo pages.
7345bc2
to
e57403e
Compare
This has been resolved. |
e57403e
to
1891099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
53736d1
to
5493074
Compare
5493074
to
7718764
Compare
7718764
to
3160336
Compare
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Add support for fully customized toast notifications, enabling custom SVG icons, color customization, and the ability to disable auto-hide. Update documentation to reflect these new customization options.
New Features:
Enhancements:
Documentation: