Fix Heretic Profiles and Search

[cinderblocks]

Reinstate objectively better Alchemy profiles and search. Ain't no thang.

[cinderblocks]

@RyeMutt

[DarlCat]

These menu items need to be preserved from the default skin as they don't appear to me to exist in the Heretic profile.

• Upload photo: Allows for free profile photo uploads, different from normal texture uploader
• Edit display name: Only mechanism to do this, my.secondlife functionality was removed

Additionally here are some merge check failures. I'm honestly not certain if those come from this PR or the canonical branch; didn't check so am not assigning blame there.

[cinderblocks]

Whurks now

                                     `$/              
           __                        O$               
       _.-"  )                        $'              
    .-"`. .-":        o      ___     ($o              
 .-".-  .'   ;      ,st+.  .' , \    ($               
:_..-+""    :       T   "^T==^;\;;-._ $\              
   """"-,   ;       '    /  `-:-// / )$/              
        :   ;           /   /  :/ / /dP               
        :   :          /   :    )^-:_.l               
        ;    ;        /    ;    `.___, \           .-,
       :     :       :  /  ;.-"""   \   \"""-,    /  ;
       ;   :  ;      ; :   :         \   \    \ .'  / 
       ;   ;  :      ;   _.:          ;   \  .-"   /l 
       ;.__L_.:   .-";  :  ;          :_   \/ .-" / ; 
       :      ;.-"   :  ; :        _  : \  / /  .' /  
        ;            ;  ;  ;   _.-" "-.\ :/   .'  :   
        :            ;  ;  :.-j-,      `;:_.+'    ;   
        ;           _;  :  :.'  ;      / : /     :    
        '-._..__.--"/   :  :   /      /  ;/      ;    
                   :    ;  ;  /      ,  //      :     
                   ;    ; / .'( ,    ; ::\     .:     
                   :    :  / .-dP-'  ;-'; `---' :     
                    `.   "" ' s")  .'  /        '     
                      \           /;  :       .'      
                    _  "-, ;       '.  \    .'        
                   / "-.'  :    .--.___.`--'          
                  /      . :  .'                      
                  )_..._  \  :  bug                   
                 : \    '. ; ;                        
                 ;  \    ;   :                        
                 :   \  /    ;                        
                  \   )/    /                         
                   `-.___.-'

[cinderblocks]

Seems like all that was already working. I didn't touch anywhere near those menus.

[DarlCat]

1. I am not seeing the menu functionality that I showed from the default/Alchemy skin
   
2. How do I create a pick?
   
3. Also sorry forgot to mention 1st life profile should also have the upload profile pic button
   

[cinderblocks]

Create Pick has been under the Places panel since Viewer2's inception 15 years ago. Editing display name is achieved by double clicking the profile name as it has been since these profiles were developed for Alchemy 10 years ago.

[DarlCat]

I'm not seeing anything for picks in the places panel on any of its tabs or menus, can you please help me by identifying what I am missing?

[cinderblocks]

https://www.youtube.com/watch?v=9vQWWG3x0Do

[cinderblocks]

Adapting to this hackish LLProfileImageCtrl, hold the line.

[DarlCat]

I am not certain what I am missing here, because Me -> Picks... directs me to the profile with the picks accordion expanded.

[cinderblocks]

Right clicking the profile images now creates a flyout menu with Upload, Change, and Remove image options.

[cinderblocks]

How to create a pick is not relevant to this PR, but you do it like this:

[DarlCat]

LGTM

[DarlCat]

Spoke too soon sorry

1. Picks is double nested
2. How to delete a pick? - Figured it out
   

[cinderblocks]

There are two accordian tabs there, one for Picks one for Classifieds. If there are no items, the accordian tab for that category is hidden. This is a carryover from the original V2 panel design.

[DarlCat]

All's good then, thanks for the requested changes! Been a long time since I v2'd and it shows lol

[cinderblocks]

Incidentally, if there are no groups (and it isn't your profile) the Groups accordion tab is also hidden.

Picks could be rewritten to be controllable from the profile (a la Firestorm) but that requires duplicating a fair amount of work that still resides in Places (and LLProfilePicks). There would be triplicate functionality across the project at that point and excessive technical debt maintaining it. Places itself is the LLSideTrayPanelContainer bitch from hell that just won't die. Tried decoupling it years ago, and it's just a pain the ass. Likely why it survived the original side panel container purge. At this point though, all functionality is restored to Heretic profiles.