Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smallvec support #162

Closed
wants to merge 3 commits into from
Closed

Add smallvec support #162

wants to merge 3 commits into from

Conversation

HactarCE
Copy link

@HactarCE HactarCE commented Aug 8, 2023

No description provided.

@NyxCode
Copy link
Collaborator

NyxCode commented Aug 8, 2023

thanks! can you also update the documantation like this?

@HactarCE
Copy link
Author

HactarCE commented Aug 8, 2023

Done! Anything else?

@escritorio-gustavo
Copy link
Contributor

Can you resolve the merge conflict and run cargo readme again?

@escritorio-gustavo
Copy link
Contributor

One more thing, can you add sme tests for this feature in the ts-rs/tests directory?

@escritorio-gustavo escritorio-gustavo added the enhancement New feature or request label Jan 26, 2024
@escritorio-gustavo
Copy link
Contributor

This has been stale for some time, and #[ts(as = "Vec<T>")] is probably a drop in replacement for this so I'll close this for now. If there is still interest in this, feel free to reopen the PR and merge main into your branch to resolve the merge conflicts

@oscartbeaumont oscartbeaumont mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HactarCE @NyxCode @escritorio-gustavo