Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema syntax for sqlite 3.4.1 #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smargoli2
Copy link

Extension doesn't work with newest version of sqlite3, updated syntax.
See issue #235

@smargoli2 smargoli2 changed the title Update syntax Update schema syntax for sqlite 3.4.1 Aug 22, 2023
@ghost ghost mentioned this pull request Sep 1, 2023
@jmforsythe
Copy link

This fixes the issues reported in
#235 #236 #237 #238 #240 #242 #244

While waiting for this to be merged in, a temporary fix I'm using is

A different fix for this: I went to C:\Users<me>.vscode\extensions\alexcvzz.vscode-sqlite-0.14.1\dist\extension.js
At line 1, column 29338 you want to replace
type=\"table"\ OR type=\"view\" with type='table' OR type='view'

@yigitkalan
Copy link

This is working for me too

Copy link

@n3rdw1z4rd n3rdw1z4rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is still working for me on version 0.14.1

Kernel: x86_64 Linux 6.10.5-zen1-1-zen

@eriviere-b
Copy link

It worked for me as well.

@cmosguy
Copy link

cmosguy commented Dec 13, 2024

well done @smargoli2 ! This PR is a god send.

Now, that this is available, how do we deploy this so that other folks can use this update. The maintainer @AlexCovizzi is no longer maintaining this project. What do folks do about situations like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants