We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
there are lot of code that need to consider what kind of the connection, tcp or udp or ws, which let the code logic complex.
So suggest to separate udp/tcp/ws code logic.
For example, a interface can be defined:
type ProtocolHandler interface { handleLoop() handlePackage() }
Assign matched ProtocolHandler to a protocol, not check the type of connection in handler logic, make the logic simple.
The text was updated successfully, but these errors were encountered:
A good suggestion. I will do it in some days later.
Sorry, something went wrong.
Merge pull request AlexStocks#24 from pantianying/pty_getty
6de78d9
Fix: cpu 100% in session.handleLoop
@wongoo would u try to do it? because i am so familiar with getty that i have no idea how to split them.
No branches or pull requests
there are lot of code that need to consider what kind of the connection, tcp or udp or ws, which let the code logic complex.
So suggest to separate udp/tcp/ws code logic.
For example, a interface can be defined:
Assign matched ProtocolHandler to a protocol, not check the type of connection in handler logic, make the logic simple.
The text was updated successfully, but these errors were encountered: