[tech debt] remove web engine windows build (flutter#160573)

It takes 30 minutes while all other bots are done in 10-20 minutes. The old Windows build used to test in IE11 and old Edge. Since we stopped testing on those we switched to Chromium, but that doesn't provide any extra signal in addition to what we get from Linux Chromium already.
AlexV525 · Dec 19, 2024 · b79ee92 · b79ee92
1 parent 0fcb6aa
commit b79ee92
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 154 deletions.
diff --git a/engine/src/flutter/ci/builders/linux_web_engine.json b/engine/src/flutter/ci/builders/linux_web_engine.json
@@ -17,7 +17,6 @@
       "gn": [
         "--web",
         "--runtime-mode=release",
-        "--no-rbe",
         "--no-goma"
       ],
       "ninja": {
@@ -570,158 +569,6 @@
           "script": "flutter/lib/web_ui/dev/felt"
         }
       ]
-    },
-    {
-      "name": "Windows run chrome suites",
-      "recipe": "engine_v2/tester_engine",
-      "drone_dimensions": [
-        "device_type=none",
-        "os=Windows"
-      ],
-      "gclient_variables": {
-        "download_android_deps": false,
-        "download_jdk": false
-      },
-      "dependencies": [
-        "web_tests/artifacts",
-        "web_tests/test_bundles/dart2js-html-html",
-        "web_tests/test_bundles/dart2js-html-ui",
-        "web_tests/test_bundles/dart2js-canvaskit-engine",
-        "web_tests/test_bundles/dart2js-canvaskit-canvaskit",
-        "web_tests/test_bundles/dart2js-canvaskit-ui",
-        "web_tests/test_bundles/dart2wasm-canvaskit-engine",
-        "web_tests/test_bundles/dart2wasm-skwasm-ui",
-        "web_tests/test_bundles/fallbacks"
-      ],
-      "test_dependencies": [
-        {
-          "dependency": "goldctl",
-          "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
-        },
-        {
-          "dependency": "chrome_and_driver",
-          "version": "125.0.6422.141"
-        }
-      ],
-      "tasks": [
-        {
-          "name": "run suite chrome-dart2js-html-html",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-dart2js-html-html"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-dart2js-html-ui",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-dart2js-html-ui"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-dart2js-canvaskit-engine",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-dart2js-canvaskit-engine"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-dart2js-canvaskit-canvaskit",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-dart2js-canvaskit-canvaskit"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-dart2js-canvaskit-ui",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-dart2js-canvaskit-ui"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-full-dart2js-canvaskit-canvaskit",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-full-dart2js-canvaskit-canvaskit"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-full-dart2js-canvaskit-ui",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-full-dart2js-canvaskit-ui"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-dart2wasm-canvaskit-engine",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-dart2wasm-canvaskit-engine"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-coi-dart2wasm-skwasm-ui",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-coi-dart2wasm-skwasm-ui"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-force-st-dart2wasm-skwasm-ui",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-force-st-dart2wasm-skwasm-ui"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-fallbacks",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-fallbacks"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-coi-fallbacks",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-coi-fallbacks"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        },
-        {
-          "name": "run suite chrome-force-st-fallbacks",
-          "parameters": [
-            "test",
-            "--run",
-            "--suite=chrome-force-st-fallbacks"
-          ],
-          "script": "flutter/lib/web_ui/dev/felt"
-        }
-      ]
     }
   ]
 }
diff --git a/engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart b/engine/src/flutter/lib/web_ui/dev/generate_builder_json.dart
@@ -146,7 +146,6 @@ class GenerateBuilderJsonCommand extends Command<bool> {
       _getTestStepForPlatformAndBrowser(suites, packageLock, 'Linux', BrowserName.chrome),
       _getTestStepForPlatformAndBrowser(suites, packageLock, 'Linux', BrowserName.firefox),
       _getTestStepForPlatformAndBrowser(suites, packageLock, 'Mac', BrowserName.safari, specificOS: 'Mac-13', cpu: 'arm64'),
-      _getTestStepForPlatformAndBrowser(suites, packageLock, 'Windows', BrowserName.chrome)
     ];
   }