Detalles Finales, corrigiendo issues de sonar

AlexVelezLl · Apr 26, 2020 · b363076 · b363076
1 parent d0aa209
commit b363076
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 2 deletions.
diff --git a/TyperBalloons/.sonar/sonar-report.json b/TyperBalloons/.sonar/sonar-report.json
@@ -1 +1 @@
-{"version":"6.7.7.38951","issues":[{"key":"016CF81D1C40B3D979","component":"TyperBalloons:src/vistas/VistaJuego1.java","line":85,"startLine":85,"startOffset":16,"endLine":85,"endOffset":30,"message":"Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.","severity":"CRITICAL","rule":"squid:S3776","status":"OPEN","isNew":true,"effortToFix":8.0}],"components":[{"key":"TyperBalloons"},{"key":"TyperBalloons:src/controlador/Controlador.java","path":"src/controlador/Controlador.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Dificultad.java","path":"src/modelo/Dificultad.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/ExcepcionPalabraNoValida.java","path":"src/modelo/ExcepcionPalabraNoValida.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Globo.java","path":"src/modelo/Globo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboAmarillo.java","path":"src/modelo/GloboAmarillo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboMalo.java","path":"src/modelo/GloboMalo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboRojo.java","path":"src/modelo/GloboRojo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboVerde.java","path":"src/modelo/GloboVerde.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Juego.java","path":"src/modelo/Juego.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/MoverGlobo.java","path":"src/modelo/MoverGlobo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Score.java","path":"src/modelo/Score.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/CONSTANTES.java","path":"src/utilities/CONSTANTES.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/Utilities.java","path":"src/utilities/Utilities.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/TyperBalloons.java","path":"src/vistas/TyperBalloons.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaInicio.java","path":"src/vistas/VistaInicio.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego1.java","path":"src/vistas/VistaJuego1.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego2.java","path":"src/vistas/VistaJuego2.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src","path":"src","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos","path":"src/Recursos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/imagenes","path":"src/Recursos/imagenes","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/sonidos","path":"src/Recursos/sonidos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/controlador","path":"src/controlador","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/data","path":"src/data","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/modelo","path":"src/modelo","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/myFonts","path":"src/myFonts","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/utilities","path":"src/utilities","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/vistas","path":"src/vistas","moduleKey":"TyperBalloons"}],"rules":[{"key":"squid:S3776","rule":"S3776","repository":"squid","name":"Cognitive Complexity of methods should not be too high"}],"users":[]}
+{"version":"6.7.7.38951","issues":[],"components":[{"key":"TyperBalloons"},{"key":"TyperBalloons:src/controlador/Controlador.java","path":"src/controlador/Controlador.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Dificultad.java","path":"src/modelo/Dificultad.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/ExcepcionPalabraNoValida.java","path":"src/modelo/ExcepcionPalabraNoValida.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Globo.java","path":"src/modelo/Globo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboAmarillo.java","path":"src/modelo/GloboAmarillo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboMalo.java","path":"src/modelo/GloboMalo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboRojo.java","path":"src/modelo/GloboRojo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboVerde.java","path":"src/modelo/GloboVerde.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Juego.java","path":"src/modelo/Juego.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/MoverGlobo.java","path":"src/modelo/MoverGlobo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Score.java","path":"src/modelo/Score.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/CONSTANTES.java","path":"src/utilities/CONSTANTES.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/Utilities.java","path":"src/utilities/Utilities.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/TyperBalloons.java","path":"src/vistas/TyperBalloons.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaInicio.java","path":"src/vistas/VistaInicio.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego1.java","path":"src/vistas/VistaJuego1.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego2.java","path":"src/vistas/VistaJuego2.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/Recursos","path":"src/Recursos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/imagenes","path":"src/Recursos/imagenes","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/sonidos","path":"src/Recursos/sonidos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/controlador","path":"src/controlador","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/data","path":"src/data","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/modelo","path":"src/modelo","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/myFonts","path":"src/myFonts","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/utilities","path":"src/utilities","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/vistas","path":"src/vistas","moduleKey":"TyperBalloons"}],"rules":[],"users":[]}
diff --git a/TyperBalloons/src/TyperBalloons.jar b/TyperBalloons/src/TyperBalloons.jar
diff --git a/TyperBalloons/src/data/scores.dat b/TyperBalloons/src/data/scores.dat
diff --git a/TyperBalloons/src/utilities/Utilities.java b/TyperBalloons/src/utilities/Utilities.java
@@ -30,7 +30,7 @@
 public final class Utilities {
     private static MediaPlayer mp;
     private Utilities(){}
-    private static Image imgBlock=new Image(CONSTANTES.RUTA_IMGS+"BG_Block.png");
+    private static final Image imgBlock=new Image(CONSTANTES.RUTA_IMGS+"BG_Block.png");
     /**
      * Metodo que sirve para hacer una trancision entre dos roots pane en la misma escena
      * En la que aparecen muchos globos flotando hacia arriba.
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		{"version":"6.7.7.38951","issues":[{"key":"016CF81D1C40B3D979","component":"TyperBalloons:src/vistas/VistaJuego1.java","line":85,"startLine":85,"startOffset":16,"endLine":85,"endOffset":30,"message":"Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.","severity":"CRITICAL","rule":"squid:S3776","status":"OPEN","isNew":true,"effortToFix":8.0}],"components":[{"key":"TyperBalloons"},{"key":"TyperBalloons:src/controlador/Controlador.java","path":"src/controlador/Controlador.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Dificultad.java","path":"src/modelo/Dificultad.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/ExcepcionPalabraNoValida.java","path":"src/modelo/ExcepcionPalabraNoValida.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Globo.java","path":"src/modelo/Globo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboAmarillo.java","path":"src/modelo/GloboAmarillo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboMalo.java","path":"src/modelo/GloboMalo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboRojo.java","path":"src/modelo/GloboRojo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboVerde.java","path":"src/modelo/GloboVerde.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Juego.java","path":"src/modelo/Juego.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/MoverGlobo.java","path":"src/modelo/MoverGlobo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Score.java","path":"src/modelo/Score.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/CONSTANTES.java","path":"src/utilities/CONSTANTES.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/Utilities.java","path":"src/utilities/Utilities.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/TyperBalloons.java","path":"src/vistas/TyperBalloons.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaInicio.java","path":"src/vistas/VistaInicio.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego1.java","path":"src/vistas/VistaJuego1.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego2.java","path":"src/vistas/VistaJuego2.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src","path":"src","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos","path":"src/Recursos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/imagenes","path":"src/Recursos/imagenes","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/sonidos","path":"src/Recursos/sonidos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/controlador","path":"src/controlador","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/data","path":"src/data","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/modelo","path":"src/modelo","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/myFonts","path":"src/myFonts","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/utilities","path":"src/utilities","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/vistas","path":"src/vistas","moduleKey":"TyperBalloons"}],"rules":[{"key":"squid:S3776","rule":"S3776","repository":"squid","name":"Cognitive Complexity of methods should not be too high"}],"users":[]}
		{"version":"6.7.7.38951","issues":[],"components":[{"key":"TyperBalloons"},{"key":"TyperBalloons:src/controlador/Controlador.java","path":"src/controlador/Controlador.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Dificultad.java","path":"src/modelo/Dificultad.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/ExcepcionPalabraNoValida.java","path":"src/modelo/ExcepcionPalabraNoValida.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Globo.java","path":"src/modelo/Globo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboAmarillo.java","path":"src/modelo/GloboAmarillo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboMalo.java","path":"src/modelo/GloboMalo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboRojo.java","path":"src/modelo/GloboRojo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/GloboVerde.java","path":"src/modelo/GloboVerde.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Juego.java","path":"src/modelo/Juego.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/MoverGlobo.java","path":"src/modelo/MoverGlobo.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/modelo/Score.java","path":"src/modelo/Score.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/CONSTANTES.java","path":"src/utilities/CONSTANTES.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/utilities/Utilities.java","path":"src/utilities/Utilities.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/TyperBalloons.java","path":"src/vistas/TyperBalloons.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaInicio.java","path":"src/vistas/VistaInicio.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego1.java","path":"src/vistas/VistaJuego1.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/vistas/VistaJuego2.java","path":"src/vistas/VistaJuego2.java","moduleKey":"TyperBalloons","status":"ADDED"},{"key":"TyperBalloons:src/Recursos","path":"src/Recursos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/imagenes","path":"src/Recursos/imagenes","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/Recursos/sonidos","path":"src/Recursos/sonidos","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/controlador","path":"src/controlador","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/data","path":"src/data","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/modelo","path":"src/modelo","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/myFonts","path":"src/myFonts","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/utilities","path":"src/utilities","moduleKey":"TyperBalloons"},{"key":"TyperBalloons:src/vistas","path":"src/vistas","moduleKey":"TyperBalloons"}],"rules":[],"users":[]}