Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toml as dependency for pyproject.toml checking #6

Merged
merged 1 commit into from
May 24, 2022
Merged

Add toml as dependency for pyproject.toml checking #6

merged 1 commit into from
May 24, 2022

Conversation

ptxmac
Copy link
Contributor

@ptxmac ptxmac commented Jan 12, 2022

This solves a problem with python projects based on recent versions of setuptools.
These require a pyproject.toml file which can be checked by yapf, but only if the toml package is installed

miguelcarcamov
miguelcarcamov suggested changes May 24, 2022
View reviewed changes
Copy link

@miguelcarcamov miguelcarcamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, it will install toml and projects using a pyproject.toml file will be able to use this action

@AlexanderMelde AlexanderMelde merged commit c1a25f7 into AlexanderMelde:master May 24, 2022
@AlexanderMelde
Copy link
Owner

Sorry I ignored this PR, guess I was sleeping 😴
Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelcarcamov miguelcarcamov miguelcarcamov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptxmac @AlexanderMelde @miguelcarcamov