fix: make project compile without errors for both unit and e2e #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tsc errors so whole project with all code is compiled without errors, this is the demanded behaviour, it has one major caveat though -> testcafe's handling of TSC
because testcafe is not consuming user's provided tsconfig.json it will fail ofc, because there is no
"skipLibCheck": true
in testcafe's code.Otherwise this is the "only right" solution how to compile whole project if Mocha/Testcafe is used ( which is needed , why ? -->
src/
( this makes also TS very important, everything has 100% type safe contract implementation <--> tests, yummy )Why this (works) ?:
test
function, typescript consumes this with little issues which are resolved viaskipLibCheck
Overall summary:
tests
it usesmocha
type definition which may fail one day if whoever from those two ( TC, Mocha ) changes it's apisglobal
types cc @DanielRosenwasser @mhegazyThe correct way?:
--> this is still not doable, because as I've mentioned, testcafe is unable to consume users tsconfig :(