Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support default gradle version coming with RN #205

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

CptFabulouso
Copy link
Contributor

Project created by react-native init .. won't compile because implementation() is not supported by specified gradle version

@zoontek zoontek merged commit b45bd67 into AlexanderZaytsev:master Jul 18, 2018
@vanlooverenkoen
Copy link

This is an invalid merge. implementation should be used everywhere. The react-native init is outdated. but you should update it yourself. No need to revert to compile. Compile is depricated

@CptFabulouso
Copy link
Contributor Author

This library is built to work with react-native, so in my opinion it should follow react-native configuration and not force users to update gradle.
Even though you will be warned that compile is depricated during compilatation if you update your gradle, it will still compile the project, but with older (RN default) version and using implementation it won't.

@vanlooverenkoen
Copy link

In my opinion if you build a library you don't want to use outdated versions. React native init istself is outdated as well. Where I work we never use react native init. we build our own template project. This way the template project is never outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants