Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python folding is not working ok, if lines have line-comments #5785

Closed
adoeller opened this issue Nov 19, 2024 · 3 comments
Closed

python folding is not working ok, if lines have line-comments #5785

adoeller opened this issue Nov 19, 2024 · 3 comments
Labels

Comments

@adoeller
Copy link

    def closeEvent(self, event):
        if self.unsaved_changes:
            # Abfrage, ob gespeichert werden soll
            reply = show_custom_message_box(self, "Speichern", "Möchten Sie die ADIF-Datei vor dem Beenden speichern?", 3, True)

            if reply is True:
                self.save_to_adif()
                event.accept()  # Anwendung beenden
            elif reply is False:
                event.accept()  # Ohne Speichern beenden
            else:
                event.ignore()  # Abbrechen und Fenster offen lassen
        else:
            event.accept()  # Keine ungespeicherten Änderungen, normal beenden

grafik

@Alexey-T Alexey-T added the bug label Nov 21, 2024
@Alexey-T Alexey-T closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2024
@adoeller
Copy link
Author

just have one line of code afterwards

def closeEvent(self, event):
    if self.unsaved_changes:
        # Abfrage, ob gespeichert werden soll
        reply = show_custom_message_box(self, "Sicherheitsabfrage", "ADIF-Datei vor dem Beenden speichern?", 3, True)

        if reply is True:
            self.save_to_adif()
            event.accept()  # Anwendung beenden
        elif reply is False:
            event.accept()  # Ohne Speichern beenden
        else:
            event.ignore()  # Abbrechen und Fenster offen lassen
    else:
        event.accept()  # Keine ungespeicherten Änderungen, normal beenden

print()

@Alexey-T Alexey-T reopened this Dec 1, 2024
@Alexey-T Alexey-T closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2024
Repository owner locked and limited conversation to collaborators Dec 1, 2024
Repository owner unlocked this conversation Dec 16, 2024
@Alexey-T
Copy link
Owner

Alexey-T commented Dec 16, 2024

I have seen it better, and yes, bug is present. Python lexer cannot fold all blocks in that sample Ok. with final line print() it cannot fold last line. and it cannot fold OK some middle blocks inside that block too.

Screenshot from 2024-12-16 21-38-23

line-comments make this broken. bug.

@Alexey-T Alexey-T reopened this Dec 16, 2024
@Alexey-T Alexey-T changed the title python def folding not working, if last line is indented python folding is not working ok, if lines have line-comments Dec 16, 2024
Alexey-T added a commit to Alexey-T/EControl that referenced this issue Dec 16, 2024
@Alexey-T
Copy link
Owner

should be fixed now. I will update Cud release to 1.220.0.x soon.

Alexey-T added a commit to Alexey-T/EControl that referenced this issue Dec 16, 2024
Alexey-T added a commit to Alexey-T/EControl that referenced this issue Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants