Support new alevin json files #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaclyn-taroni
approved these changes
Jul 23, 2021
Comment on lines
+128
to
+129
| quant_json <- jsonlite::fromJSON(quant_json_path) | ||
| if(quant_json$usa_mode != "TRUE"){ |
There was a problem hiding this comment.
Checking my understanding: before alevin 0.4.1 the meta_info.json indicated that something was run in USA mode and now that information is in quant.json.
There was a problem hiding this comment.
yup! They changed the filename to avoid potential conflict (salmon already had a meta_info.json file in a subdirectory) and to make it the name match the pattern of the .json files the other alevin-fry commands used. They also added some fields, but that's it.
This reverts commit c6f14b0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for alevin-fry 0.4.1, which (at my request) moved the json file for
alevin-fry quanttoquant.json. I am maintaining support for the old version for now, so we look formeta_info.jsonas backup, but we may be able to remove that in the future.