Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching script causes reader to scroll to the top #185

Closed
2 tasks done
Luciogi opened this issue Apr 4, 2023 · 9 comments · Fixed by #211 or #251
Closed
2 tasks done

Switching script causes reader to scroll to the top #185

Luciogi opened this issue Apr 4, 2023 · 9 comments · Fixed by #211 or #251
Labels
bug Something isn't working

Comments

@Luciogi
Copy link
Contributor

Luciogi commented Apr 4, 2023

Steps to reproduce

  1. Open Chapter longer than 1 page. e.g Chapter No: 2
  2. Scroll manually to page 2 or 3.
  3. Change script from Settings

Expected behavior

It should remember page position

Actual behavior

Directed to 1st page of Chapter

QuranApp version

2023.04.02.1

Android version

Android 13

Other details

output.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
@Luciogi Luciogi added the bug Something isn't working label Apr 4, 2023
@faisalcodes
Copy link
Member

It remembers the verse number when reading in translation layout mode. It should also remember in page layout mode. Will work on it 👍.

@faisalcodes faisalcodes mentioned this issue Apr 12, 2023
Merged
@Luciogi
Copy link
Contributor Author

Luciogi commented Apr 21, 2023

@faisalcodes this bug still exist
Tested in Debug version

@faisalcodes
Copy link
Member

Have you updated your branch?

@Luciogi
Copy link
Contributor Author

Luciogi commented Apr 21, 2023

Yes, it is uptodate

@faisalcodes
Copy link
Member

Kindly send a recording.

@faisalcodes
Copy link
Member

@Luciogi Kindly join our discord server for detailed discussion.

@Luciogi
Copy link
Contributor Author

Luciogi commented Apr 21, 2023

screen-20230421-201841.mp4

@Luciogi
Copy link
Contributor Author

Luciogi commented Apr 21, 2023

@Luciogi Kindly join our discord server for detailed discussion.

I was banned from discord, I wont want to use it anymore.
I would Like to Invite to Matrix chat

@faisalcodes
Copy link
Member

We have matrix as well.

@faisalcodes faisalcodes reopened this Apr 21, 2023
@faisalcodes faisalcodes changed the title Switching script cause scrolls to 1st page of chapter Switching script causes reader to scroll to the top Apr 22, 2023
faisalcodes added a commit to faisalcodes/QuranApp that referenced this issue Apr 22, 2023
@faisalcodes
Improvements in Quran reader (Closes AlfaazPlus#185)
5c96d6f
@faisalcodes faisalcodes mentioned this issue Apr 22, 2023
Merged
faisalcodes added a commit that referenced this issue Apr 22, 2023
@faisalcodes
Merge pull request #251 from faisalcodes/master
8421e58 
Improvements in Quran reader (Closes #185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@faisalcodes @Luciogi