AAE-21850 Clean up skip PRs condition

[tomgny]

Checklist

• Jira Reference (also in PR title):
• README updated after adding/changing behaviour of an action
• Proposed version increment for release:
  • Patch (bugfix)
  • Minor (new feature)
  • Major (breaking changes)
• External PR link where changes has been tested:

Description

[atchertchian]

I'm starting to think that instead of adding so many exceptions to this list, since the "upstream" and "release" use cases are very specific to the single monorepo, maybe "whitelist-branches" should be used instead here, see doc at https://github.com/Alfresco/alfresco-build-tools?tab=readme-ov-file#enforce-pr-conventions
The only thing I'm not sure of is whether wildcards "upstream-" and "release-" would be handled correctly so that should be checked.

Overall I'd be in favor of keeping only "pr-*" in that line, that matches the generic dependabot use case (and was the original intent of this step).

WDYT please? cc @mauriziovitale @andrea-ligios

[gionn]

there is a whitelist-branches input for avoiding hardcoding branches here, which can change depending on the target repo

[mauriziovitale]

as @atchertchian mentioned above most probably we need a wildcard as suffix

        for branch in "${branches[@]}"; do
            if [[ $branch == $BRANCH_NAME ]]; then
            
  Or I am not sure if u can pass something like release-* as value