AAE-23095 Branch name length strategy #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,6 +75,7 @@ runs: | |||
| run: | | |||
| REPOSITORY=${DIR##*/} | |||
| TAG="${TAG:-$(echo ${GITHUB_HEAD_REF:-$GITHUB_REF_NAME} | sed -e 's/[^-_.[:alnum:]]/_/g')}" | |||
| TAG="${TAG:0:128}" | |||
There was a problem hiding this comment.
Nitpick: if the tag originally comes from the action input, I don't think we should modify it, and let it fail if it's too long.
For the fallback tag (second part of expression 1 line above), we can cut it, but I wonder if we need to use the branch name on PRs, maybe relying on GITHUB_REF_NAME for all use cases is better ("<pr_number>/merge" would be the value on PRs)
There was a problem hiding this comment.
thanks, set limitation only on generated value
atchertchian
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Some branch names are too long, which causes tag name longer than maximum 128 characters