AAE-23198 Dependency Graph Submission on push in common build action #643
Conversation
| uses: advanced-security/maven-dependency-submission-action@5d0f9011b55d6268922128af45275986303459c3 # v4.0.3 | ||
| env: | ||
| MAVEN_USERNAME: ${{ inputs.maven-username }} | ||
| MAVEN_PASSWORD: ${{ inputs.maven-password }} |
There was a problem hiding this comment.
what about settings file?
please also rename the PR title to more meaningful
There was a problem hiding this comment.
thanks, done
Did a test pr to check it and it works https://github.com/Alfresco/alfresco-identity-adapter-service/actions/runs/9515759065/job/26230694053?pr=925
There was a problem hiding this comment.
looking at extra dependencies retrieved by this build, I wonder if it should be in the saved cache (so this step should be higher), wdyt?
also I'm not sure where the result is visible/uploaded: you gave a link to the PR but this is not supposed to be run on PRs, am I missing something?
There was a problem hiding this comment.
I moved it even higher; that action may use dependencies removed on the end.
There is no direct clickable result, GH analyzes the output and creates security issues like this: https://github.com/Alfresco/hxp-process-services/security/dependabot/23
wojciech-piotrowiak
force-pushed
the
feature/AAE-23198-submission-action-in-build
branch
from
0f422a2 to
4c4db5b
Compare
wojciech-piotrowiak
changed the title
wojciech-piotrowiak
deleted the
feature/AAE-23198-submission-action-in-build
branch
Checklist
Description