Skip to content

Commit

Permalink
[AAE-17674] Solve deprecation warning in the theme creation (#9222)
Browse files Browse the repository at this point in the history
* [AAE-17674] Solve deprecation warning in the theme creation

 Solve deprecation warning in the theme creation

* Update custom-palette-creator.scss

* Update custom-palette-creator.scss

* Update custom-palette-creator.scss

* fix upgrade download upload

* fix upgrade download upload

* Revert "fix upgrade download upload"

This reverts commit 1241b9d.
  • Loading branch information
eromano authored Jan 15, 2024
1 parent 4e328ea commit bb3dd97
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 14 deletions.
6 changes: 4 additions & 2 deletions .github/actions/artifact-append/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ runs:
- run: echo "Artifact Append"
shell: bash
- name: Download artifact
uses: actions/download-artifact@f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110 # v4.1.0
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: ${{ inputs.artifact-name }}
pattern: ${{ inputs.artifact-name }}-*
merge-multiple: true
- run: ls
shell: bash
- name: Append content
Expand Down Expand Up @@ -83,7 +85,7 @@ runs:
}
}
- name: Upload artifact
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: ${{ inputs.artifact-name }}
path: ${{ inputs.file-name }}
Expand Down
4 changes: 3 additions & 1 deletion .github/actions/artifact-extract/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@ runs:
- run: echo "Artifact Extract"
shell: bash
- name: Download artifact
uses: actions/download-artifact@f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110 # v4.1.0
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: ${{ inputs.artifact-name }}
pattern: ${{ inputs.artifact-name }}-*
merge-multiple: true
- id: extract
shell: bash
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/artifact-initialize/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ runs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Create empty artifact
shell: bash
run:
run:
echo "${{inputs.content}}" > ${{ inputs.file-name }}

- name: Upload artifact
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: ${{ inputs.artifact-name }}
path: ${{ inputs.file-name }}
4 changes: 2 additions & 2 deletions .github/actions/e2e/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,14 @@ runs:
if: ${{ steps.determine-affected.outputs.isAffected == 'true' && github.event_name == 'schedule' && failure() }}
uses: ./.github/actions/artifact-append
with:
artifact-name: global-e2e-result
artifact-name: "global-e2e-result-${{ inputs.e2e-test-id }}"
file-name: e2e-failures.txt
content: "${{ inputs.e2e-test-id }}"

- name: upload artifacts on gh
id: upload_gh
if: ${{ steps.determine-affected.outputs.isAffected == 'true' }}
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: e2e-artifact-output
path: /home/runner/work/alfresco-ng2-components/alfresco-ng2-components/e2e-output-*
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ jobs:
if: ${{ github.event_name == 'schedule' }}
uses: ./.github/actions/artifact-extract
with:
artifact-name: global-e2e-result
artifact-name: "global-e2e-result-${{ matrix.e2e-test.test-id }}"
file-name: e2e-failures.txt
- name: identify-slack-group
id: groups
Expand Down
12 changes: 6 additions & 6 deletions lib/core/custom-theme/theme/custom-palette-creator.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
@use 'sass:color';

@function multiply($fore, $back) {
$red: color.red($back) * color.red($fore) / 255;
$green: color.green($back) * color.green($fore) / 255;
$blue: color.blue($back) * color.blue($fore) / 255;
$red: math.div(color.red($back) * color.red($fore), 255);
$green: math.div(color.green($back) * color.green($fore), 255);
$blue: math.div(color.blue($back) * color.blue($fore), 255)

@return rgb($red, $green, $blue);
}
Expand All @@ -19,12 +19,12 @@

@each $name, $value in $colors {
$adjusted: 0;
$value: $value / 255;
$value: math.div($value, 255);

@if ($value < 0.0393) {
$value: $value / 12.92;
$value: math.div($value, 12.92);
} @else {
$value: ($value + 0.055) / 1.055;
$value: math.div($value + 0.055, 1.055);
$value: math.pow($value, 2.4);
}

Expand Down

0 comments on commit bb3dd97

Please sign in to comment.