Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack to the demo shell #1026

Closed
5 of 12 tasks
magemello opened this issue Nov 8, 2016 · 3 comments
Closed
5 of 12 tasks

Add webpack to the demo shell #1026

magemello opened this issue Nov 8, 2016 · 3 comments
Assignees
Milestone

Comments

@magemello
Copy link
Contributor

magemello commented Nov 8, 2016

Major actions:

  • remove module.id from all components
  • remove @types/core-js from all components (due to conflicts), replaced with tsconfig.json extensions
  • ensure i18n, images and external templates are loading
  • upgrade demo shell to use webpack 1 (official released version)
  • unit testing support for demo shell
  • provide documentation updates for all components affected
  • tslint configuration for webpack

Optional:

  • move dependencies to demo projects (polyfills, MDL and other should be part of demo project and not of the component library)
  • migrate unit tests for all components to webpack
  • upgrade code coverage configuration for all components
  • migrate project demos for all components to webpack
  • provide sever configuration for demo shell bundle (when building in production mode)
@DenysVuika
Copy link
Contributor

Changes related to webpack should be also ported to yeoman app generator.

@magemello magemello self-assigned this Nov 21, 2016
@magemello magemello modified the milestones: 1.0.0, 0.5.0 Nov 25, 2016
@magemello
Copy link
Contributor Author

The demo shell works with webpack and angular-cli. To do so I had to change all the templates and the css of the components and require it, also introduce a gulp task that copy all the images and the internationalization files in the demo shell. This bring 2 problems:

  1. All the test are broken
  2. All the components demo are broken

Now we have 2 choices :

  1. Find the way to make the demo-shell working without to require all the template and the css in the components.
  2. Fix the tests and the demos :)

@DenysVuika
Copy link
Contributor

I am not sure about angular-cli support at this point. Couple of cli commands may work but we have no support for entire cli.

@magemello magemello removed their assignment Nov 30, 2016
magemello added a commit that referenced this issue Dec 15, 2016
@magemello magemello self-assigned this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants