[ACS-8312] Display warning about losing response #10059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekpluta
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
jacekpluta
force-pushed
the
ACS-8312-Display-warning-about-losing-response
branch
from
da5bf2c to
da7652a
Compare
jacekpluta
force-pushed
the
ACS-8312-Display-warning-about-losing-response
branch
2 times, most recently
from
8df9fdd to
e0bae5a
Compare
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.html
Outdated
Show resolved
Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.html
Outdated
Show resolved
Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.spec.ts
Outdated
Show resolved
Hide resolved
MichalKinas
reviewed
Aug 8, 2024
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.html
Outdated
Show resolved
Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.html
Outdated
Show resolved
Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.html
Outdated
Show resolved
Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes-dialog.component.html
Outdated
Show resolved
Hide resolved
| }) | ||
| export class UnsavedChangesDialogComponent {} | ||
| export class UnsavedChangesDialogComponent { | ||
| private readonly unsavedAiChangesModalVisible = 'unsaved_ai_changes__modal_visible'; |
There was a problem hiding this comment.
Let's keep it as global variable on the core level so that it can be reused in other repos
There was a problem hiding this comment.
done. moved it to other local storage variables
jacekpluta
force-pushed
the
ACS-8312-Display-warning-about-losing-response
branch
from
e0bae5a to
f096b69
Compare
jacekpluta
force-pushed
the
ACS-8312-Display-warning-about-losing-response
branch
from
f096b69 to
6b066f2
Compare
|
swapnil-verma-gl
approved these changes
Aug 12, 2024
MichalKinas
approved these changes
Aug 12, 2024
| } | ||
|
|
||
| /** | ||
| * Sets 'unsaved_ai_changes__modal_visible' checked state (true or false string) as new item in local storage. |
There was a problem hiding this comment.
Name should be updated here
There was a problem hiding this comment.
Oh and also let's add a mention about this functionality to the documentation of this component
AleksanderSklorz
pushed a commit
that referenced
this pull request
Aug 20, 2024
AleksanderSklorz
pushed a commit
that referenced
this pull request
Aug 26, 2024
AleksanderSklorz
pushed a commit
that referenced
this pull request
Sep 9, 2024
jacekpluta
added a commit
that referenced
this pull request
Sep 13, 2024
jacekpluta
added a commit
that referenced
this pull request
Sep 18, 2024
jacekpluta
added a commit
that referenced
this pull request
Sep 19, 2024
…selected files (#10229) * [ACS-8202] basic flow getting ai response for one or more selected files (#9944) * ACS-8202 Getting list of agents * ACS-8202 Mocked agents, used base api from hxi connector * ACS-8202 Search Ai service * ACS-8202 Small correction and mocked data * ACS-8202 Renamed variable * ACS-8202 Added documentation * ACS-8202 Addressed PR comments * ACS-8202 Type change * ACS-8202 Reverted unwatend change * ACS-8202 Reverted unwanted change * ACS-8201 Small correction after rebasing with Angular 15 * [ACS-8398] Unit tests for agents and search ai (#9974) * ACS-8398 Unit tests for search ai api and agents api * ACS-8398 Unit tests for getAnswer function from SearchAiApi, corrections for unit tests for SearchAiApi and AgentsApi * ACS-8398 Unit tests for SearchAiService and AgentService * [ACS-8210] Agent basic details popup (#9956) * [ACS-8573] Allow user to ask question without file selection * [ACS-8312] Display warning about losing response (#10059) * [ACS-8312] Display warning about losing response * [ACS-8312] Display warning about losing response - fixes * [ACS-8432] Sending all file types to HX instead of only the text file types (#10087) * ACS-8201 Fixed issues after rebase * [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page (#10132) * [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page * [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page - review fixes * [ACS-8588] Navigation is triggered twice when leaving Knowledge Retrieval page - review fixes 2 * [ACS-8399] Integrate all changes with backend (#10163) * Answers endpoint fix (#10176) * [ACS-8664] generic question redirection to hx insight (#10174) * ACS-8664 Loading HX insight url * ACS-8664 Added documentation for loading config of Knowledge Retrieval * ACS-8664 Unit tests * ACS-8664 Fixed unit tests * ACS-8664 Fixed unit tests after rebase * ACS-8664 Addressed comment * ACS-8201 Fixed issues after rebase * [ACS-8695] Getting Agent avatar (#10189) * [ACS-8695] Getting Agent avatar * [ACS-8695] Getting Agent avatar - on image load error * [ACS-8695] Getting Agent avatar - removed getAgentAvatar call (#10209) * [ACS-8201] Review fixes --------- Co-authored-by: AleksanderSklorz <[email protected]> Co-authored-by: Aleksander Sklorz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8312
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: