[ACS-8644] Fixed issue where download button and comments section was missing on manage versions dialog #10119
Conversation
… missing on manage versions dialog
swapnil-verma-gl
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
|
Did you test with ACA? Not working for me 🤔 |
Yes, its working fine for me. Did you make sure to run local aca with adf configuration? |
| const { file, node, showVersionsOnly, showComments, allowDownload } = data; | ||
| const { file, node, showVersionsOnly } = data; | ||
| const allowDownload = data.allowDownload ?? true; | ||
| const showComments = data.showComments ?? true; |
There was a problem hiding this comment.
should we add tests here for these or it's not necessary?
There was a problem hiding this comment.
These flags are passed as data to the NewVersionUploaderDialog component, and then eventually to the VersionList component as input property. The tests for showing and hiding download button and comments section, based on the data present in that component, are already present under the unit tests for that component (here and here). So I don't think its required here anymore
DenysVuika
deleted the
dev-acs-8644-manage-versions-missing-download-comments
branch
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Download button and comments section from manage versions dialog was missing
What is the new behaviour?
Download button and comments section from manage versions dialog are now shown
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8644
Root cause analysis - comment