Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-25392 Convert route guards to functional part four #10123

Conversation

ehsan-2019
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

AAE-25392

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ehsan-2019 ehsan-2019 changed the title Improvement/aae 25392 convert route guards to functional part four AAE-25392 Convert route guards to functional part four Aug 26, 2024
@ehsan-2019 ehsan-2019 force-pushed the improvement/AAE-25392-convert-route-guards-to-functional-part-four branch 2 times, most recently from 0469a28 to 2729fb3 Compare August 29, 2024 14:54
@VitoAlbano VitoAlbano force-pushed the improvement/AAE-25392-convert-route-guards-to-functional-part-four branch from 2729fb3 to 69946eb Compare August 29, 2024 14:59
@ehsan-2019 ehsan-2019 force-pushed the improvement/AAE-25392-convert-route-guards-to-functional-part-four branch from b329557 to ce43220 Compare August 29, 2024 16:11
@ehsan-2019 ehsan-2019 force-pushed the improvement/AAE-25392-convert-route-guards-to-functional-part-four branch from 6908985 to 65ca907 Compare August 30, 2024 08:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ehsan-2019 ehsan-2019 merged commit 7be2e8f into develop Aug 30, 2024
32 of 33 checks passed
@ehsan-2019 ehsan-2019 deleted the improvement/AAE-25392-convert-route-guards-to-functional-part-four branch August 30, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants