Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-8647] Fixed issue where data table rows could not be selected when the height of the row expanded due to tags #10137

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

swapnil-verma-gl
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Rows could not be selected by clicking on the empty padded area, in case there was a large tag on that row

What is the new behaviour?
Rows can now be selected

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://hyland.atlassian.net/browse/ACS-8647

…en the height of the row expanded due to tags
Copy link

@DenysVuika
Copy link
Contributor

@swapnil-verma-gl can you give some screenshots how the results look like?

@swapnil-verma-gl
Copy link
Contributor Author

@swapnil-verma-gl can you give some screenshots how the results look like?

Visually, there is no difference between how the current implementation looks like, and what the proposed changes will do. Essentially, we are just stretching all cells in a row to occupy the full height available in the row, since the click handler is present on individual cells, instead of on the entire row. Below screenshots show the difference in cell height prior to the change, and after the change (the red color is not present in the applicaiton, and is added via browser console to highlight the difference) -

ACA (current implementation)-
image

Proposed changes -
image

@DenysVuika DenysVuika merged commit 9caf9d2 into develop Aug 29, 2024
35 checks passed
@DenysVuika DenysVuika deleted the dev-acs-8647-fix-row-height-selection branch August 29, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants