ACS-8227: remove internal mime type icon pipe #10142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysVuika
force-pushed
the
chore/remove-mime-type-icon-pipe
branch
from
55766e8 to
6d84ded
Compare
There was a problem hiding this comment.
Can we also remove the entry for originalMimeType from class properties section?
swapnil-verma-gl
previously approved these changes
Aug 30, 2024
swapnil-verma-gl
dismissed
their stale review
New finding related to updates on mimeType input property
DenysVuika
requested review from
swapnil-verma-gl,
MichalKinas and
DaryaBalvanovich
|
|
||
| if (blobFile?.currentValue) { | ||
| this.mimeType = blobFile.currentValue.type; | ||
| this.mimeTypeIconUrl = this.thumbnailService.getMimeTypeIcon(mimeType.currentValue); |
There was a problem hiding this comment.
I guess it should use either blobFile.currentValue.type or this.mimeType, instead of mimeType, since we want to cover the case where only the blobFile property was changed. But other than that, everything looks good to me.
There was a problem hiding this comment.
yes, updated the code, thanks
this.mimeTypeIconUrl = this.thumbnailService.getMimeTypeIcon(blobFile.currentValue.type);
swapnil-verma-gl
approved these changes
Sep 5, 2024
DenysVuika
force-pushed
the
chore/remove-mime-type-icon-pipe
branch
2 times, most recently
from
18828c6 to
012adbc
Compare
DenysVuika
force-pushed
the
chore/remove-mime-type-icon-pipe
branch
from
012adbc to
f99be15
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8227