-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS-8761 Noop Auth Module for unit testing ergonomics #10195
Conversation
db8cd48
to
8c041ab
Compare
lib/process-services/src/lib/people/components/people/people.component.spec.ts
Outdated
Show resolved
Hide resolved
...ib/content-metadata/components/content-metadata-card/content-metadata-card.component.spec.ts
Outdated
Show resolved
Hide resolved
...ices/src/lib/content-metadata/components/content-metadata/content-metadata.component.spec.ts
Outdated
Show resolved
Hide resolved
The incorrect import issue is present for pretty much all import of NoopTranslateModule and NoopAuthModule inside ADF-Core. Additionally, there are a couple of more occurrences of the issue in some component imports, that I've tagged individually. Many of these are pre-existing imports though, just FYI |
lib/content-services/src/lib/viewer/components/alfresco-viewer.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/dialogs/unsaved-changes-dialog/unsaved-changes.guard.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/templates/empty-content/empty-content.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/viewer/components/viewer-render/viewer-render.component.spec.ts
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Enable testbed reset after each test
Introduce a
NoopAuthModule
that provides all the necessary testing setup to avoid using:Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8761