AAE-26192 New task search API #10319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaRobert
commented
Oct 22, 2024
| import { TaskQueryCloudRequestModel } from '../../../models/filter-cloud-model'; | ||
| import { TaskCloudNodePaging } from '../../../models/task-cloud.model'; | ||
| import { TaskListCloudSortingModel } from '../../../models/task-list-sorting.model'; | ||
|
|
||
| @Injectable({ providedIn: 'root' }) | ||
| export class ProcessTaskListCloudService extends BaseCloudService implements TaskListCloudServiceInterface { |
There was a problem hiding this comment.
ProcessTaskListCloudService shouldn't implement that interface - it's not event shared between tasks and processes.
DudaRobert
commented
Oct 22, 2024
| @@ -379,4 +380,29 @@ export class TaskFilterCloudService extends BaseCloudService { | |||
| refreshFilter(filterKey: string): void { | |||
| this.filterKeyToBeRefreshedSource.next(filterKey); | |||
| } | |||
|
|
|||
| private handleBackwardCompatibility(appName: string, key: string, filters: TaskFilterCloudModel[]): Observable<TaskFilterCloudModel[]> { | |||
There was a problem hiding this comment.
This method will filre at the start of the app, when we retrieve the filters from local storage or when we first populate them.
If we don't find the new keys in the retrieved filters, but we find their old counterparts we populate the new keys and leave the counterparts as they are.
DudaRobert
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
BSekula
approved these changes
Oct 23, 2024
| @@ -28,3 +28,9 @@ export const PROCESS_FILTERS_SERVICE_TOKEN = new InjectionToken<PreferenceCloudS | |||
| export const TASK_FILTERS_SERVICE_TOKEN = new InjectionToken<PreferenceCloudServiceInterface>('task-filters-cloud'); | |||
|
|
|||
| export const TASK_LIST_CLOUD_TOKEN = new InjectionToken<TaskListCloudServiceInterface>('task-list-cloud'); | |||
|
|
|||
| /** | |||
| * Token used to indicate the method to be used while searching for tasks. | |||
There was a problem hiding this comment.
Suggested change
| * Token used to indicate the method to be used while searching for tasks. | |
| * Token used to indicate the what api to be used while searching for tasks. |
What I mean is, adding some info that we have new API 🤔
POST/GET can indicate that we have the same request url, but different HTTP method
| * @param filters Array of task filters to be checked for backward compatibility. | ||
| * @returns Observable of task filters with updated properties. | ||
| */ | ||
| private handleBackwardsCompatibility(appName: string, key: string, filters: TaskFilterCloudModel[]): Observable<TaskFilterCloudModel[]> { |
There was a problem hiding this comment.
Suggested change
| private handleBackwardsCompatibility(appName: string, key: string, filters: TaskFilterCloudModel[]): Observable<TaskFilterCloudModel[]> { | |
| private handleCreateFilterBackwardsCompatibility(appName: string, key: string, filters: TaskFilterCloudModel[]): Observable<TaskFilterCloudModel[]> { |
| return this.fetchTaskList(requestNode).pipe(map((tasks) => tasks.list.pagination.totalItems)); | ||
| } | ||
|
|
||
| protected buildQueryData(requestNode: TaskListRequestModel) { |
There was a problem hiding this comment.
can we infer return type here?
There was a problem hiding this comment.
It's just an object - even in the BaseCloudService.post method it's any
|
|
||
| Object.keys(queryData).forEach((key) => { | ||
| const value = queryData[key]; | ||
| if (value === undefined || value === null || value === '' || (Array.isArray(value) && (value.length === 0 || value[0] === null))) { |
There was a problem hiding this comment.
Suggested change
| if (value === undefined || value === null || value === '' || (Array.isArray(value) && (value.length === 0 || value[0] === null))) { | |
| const isValueEmpty = !value; | |
| const isValueEmptyArray = Array.isArray(value) && (value.length === 0 || value[0] === null); | |
| if (isValueEmpty || isValueEmptyArray) { |
DudaRobert
force-pushed
the
feature/AAE-26192-new-task-search-api
branch
2 times, most recently
from
e4fb052 to
ea60aa2
Compare
DudaRobert
force-pushed
the
feature/AAE-26192-new-task-search-api
branch
from
ea60aa2 to
6dd4231
Compare
|
eromano
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-26192
What is the new behaviour?
https://hyland.atlassian.net/browse/AAE-26192
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: