[MNT-24698] Add aspect name to the title when there are duplicated aspect titles #10374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagosalvado10
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
lib/content-services/src/lib/content-metadata/services/content-metadata.service.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/content-metadata/services/content-metadata.service.ts
Show resolved
Hide resolved
…itle equals to its name
swapnil-verma-gl
approved these changes
Nov 12, 2024
… into fix/MNT-24698_prevent-duplicated-aspect-titles
|
tiagosalvado10
deleted the
fix/MNT-24698_prevent-duplicated-aspect-titles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
When there are aspects with the same title in a custom model, the UI metadata panels will also have the same title. This situation creates a conflict which prevents the panels from being expanded/collapsed.
What is the new behaviour?
When setting the title for each metadata panel, it is now verified if the aspect title is duplicated, if so the aspect name is concatenated to the title, i.e, title (name) - This not only resolves the conflict but also allows to better distinguish aspects with the same title.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Further information can be found in this Jira comment