[ACS-8959] Introduce new takeUntilDestroyed operator where possible
#10388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
MichalKinas
approved these changes
Nov 14, 2024
dominikiwanekhyland
force-pushed
the
ACS-8959-introduce-new-take-until-destroyed-operator-where-possible
branch
3 times, most recently
from
d76c293 to
22a95ac
Compare
lib/content-services/src/lib/aspect-list/aspect-list.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/aspect-list/aspect-list.component.ts
Outdated
Show resolved
Hide resolved
...-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
Show resolved
Hide resolved
...b/content-node-selector/content-node-selector-panel/content-node-selector-panel.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/content-node-selector/content-node-selector.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/content-node-share/content-node-share.directive.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/document-list/components/document-list.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/document-list/components/document-list.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/document-list/components/filter-header/filter-header.component.ts
Outdated
Show resolved
Hide resolved
...rvices/src/lib/document-list/components/library-name-column/library-name-column.component.ts
Outdated
Show resolved
Hide resolved
...es/src/lib/document-list/components/library-status-column/library-status-column.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/document-list/components/name-column/name-column.component.ts
Outdated
Show resolved
Hide resolved
...-services/src/lib/search/components/search-datetime-range/search-datetime-range.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/tag/tag-actions/tag-actions.component.ts
Outdated
Show resolved
Hide resolved
lib/core/feature-flags/src/lib/directives/features.directive.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-dateitem/card-view-dateitem.component.ts
Outdated
Show resolved
Hide resolved
...rd-view/components/card-view-selectitem/select-filter-input/select-filter-input.component.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/datatable/components/columns-selector/columns-selector.component.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/form/components/widgets/date-time/date-time.widget.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/search/components/search-properties/search-properties.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/tag/tag-node-list/tag-node-list.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/tag/tags-creator/tags-creator.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/upload/components/file-uploading-dialog.component.ts
Show resolved
Hide resolved
lib/insights/src/lib/analytics-process/components/analytics-report-parameters.component.ts
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/people/components/people-cloud.component.ts
Outdated
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/task/start-task/components/start-task-cloud.component.ts
Show resolved
Hide resolved
...rocess-services/src/lib/process-list/components/process-filters/process-filters.component.ts
Outdated
Show resolved
Hide resolved
...s/src/lib/process-list/components/process-instance-tasks/process-instance-tasks.component.ts
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-filters/task-filters.component.ts
Outdated
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/task/task-list/components/base-task-list-cloud.component.ts
Outdated
Show resolved
Hide resolved
|
In datatable.component.ts there is some unsubscribing on subscriptions array which we can replace with takeUntilDestroyed too probably: |
@AleksanderSklorz hi, just to be sure, did you mean that one? Because that particular one was already resolved I think |
dominikiwanekhyland
force-pushed
the
ACS-8959-introduce-new-take-until-destroyed-operator-where-possible
branch
from
971e451 to
203b9c4
Compare
dominikiwanekhyland
force-pushed
the
ACS-8959-introduce-new-take-until-destroyed-operator-where-possible
branch
from
203b9c4 to
cde9555
Compare
|
AleksanderSklorz
approved these changes
Nov 19, 2024
dominikiwanekhyland
deleted the
ACS-8959-introduce-new-take-until-destroyed-operator-where-possible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: