Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to change position of the dropdown menu (left|right) #1590

Merged
merged 2 commits into from
Feb 6, 2017

Conversation

DenysVuika
Copy link
Contributor

refs #1581

@magemello
Copy link
Contributor

Can we have a couple of unit tests that checks the action be the first column and last if is left or right?

@codecov-io
Copy link

codecov-io commented Feb 3, 2017

Codecov Report

Merging #1590 into development will increase coverage by 0.02%.

@@               Coverage Diff               @@
##           development    #1590      +/-   ##
===============================================
+ Coverage         90.2%   90.23%   +0.02%     
===============================================
  Files              219      219              
  Lines             8266     8322      +56     
  Branches          1108     1117       +9     
===============================================
+ Hits              7456     7509      +53     
- Misses             810      813       +3
Impacted Files Coverage Δ
...mentlist/src/components/document-list.component.ts 83.49% <100%> (+0.08%)
...le/src/components/datatable/datatable.component.ts 88.88% <100%> (+0.13%)
...st/src/components/activiti-start-task.component.ts 90.19% <ø> (-5.89%)
...tasklist/src/services/activiti-tasklist.service.ts 88.53% <ø> (-0.64%)
...cs/src/components/analytics-generator.component.ts 90% <ø> (+2.5%)
.../src/components/analytics-report-list.component.ts 97.53% <ø> (+6.04%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18165c...00c9cb6. Read the comment docs.

@@ -23,8 +27,8 @@
<span *ngIf="col.srTitle" class="sr-only">{{col.srTitle}}</span>
<span *ngIf="col.title">{{col.title}}</span>
</th>
<!-- Actions -->
<th *ngIf="actions">
<!-- Actions (right) -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a couple of unit tests that checks the action be the first column and last if is left or right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added unit tests

@magemello magemello merged commit 7c54090 into development Feb 6, 2017
@DenysVuika DenysVuika deleted the dev-denys-1581 branch March 23, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants