[ADF-5508] Fix half hidden checkmark icon #8039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
TomikaArome
requested review from
MichalKinas,
AleksanderSklorz,
gevagel and
nikita-web-ua
MichalKinas
approved these changes
Dec 8, 2022
nikita-web-ua
approved these changes
Dec 8, 2022
DenysVuika
reviewed
Dec 8, 2022
lib/core/src/lib/datatable/components/datatable/datatable.component.scss
Outdated
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Dec 12, 2022
DenysVuika
approved these changes
Dec 12, 2022
TomikaArome
force-pushed
the
fix/dev-thunter-ADF-5508-half-hidden-checkmark
branch
from
d19eb99 to
b4e795b
Compare
DenysVuika
changed the title
DenysVuika
approved these changes
Dec 13, 2022
TomikaArome
deleted the
fix/dev-thunter-ADF-5508-half-hidden-checkmark
branch
DiogoABastos
pushed a commit
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ADF-5508
What is the new behaviour?
The checkmark is fully visible.
Note that I would like any feedback on whether this change could cause other issues if merged. In the demoshell it seems to work completely as intended but I fear elsewhere it could not.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: