[AAE-12558] Fix load content-services translation resources #8241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alep85
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
eromano
approved these changes
Feb 7, 2023
pr-triage
bot
added
PR: partially-approved
PR: unreviewed
and removed
PR: unreviewed
PR: partially-approved
labels
mauriziovitale
approved these changes
Feb 7, 2023
DenysVuika
changed the title
DenysVuika
approved these changes
Feb 7, 2023
DenysVuika
changed the title
alep85
force-pushed
the
dev-alepore-AAE-12558
branch
from
6bd9d02 to
d1c76aa
Compare
e2e/protractor.excludes.json
Outdated
| @@ -7,5 +7,7 @@ | |||
| "C260377": "https://alfresco.atlassian.net/browse/ACS-4467", | |||
| "C260375": "https://alfresco.atlassian.net/browse/ACS-4467", | |||
| "C286290": "https://alfresco.atlassian.net/browse/ACS-4467", | |||
| "C286472": "https://alfresco.atlassian.net/browse/ACS-4467" | |||
| "C286472": "https://alfresco.atlassian.net/browse/ACS-4467", | |||
| "C260387": "https://alfresco.atlassian.net/browse/ACS-4595", | |||
There was a problem hiding this comment.
@alep85 you probably don't need to exluce these e2e anymore. From today they are success, see my PR:
#8240
@AnkurChauhan-131 noticed that they work from today. Please remove them from exclude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-12558
What is the new behaviour?
Removed ContentModule import from
FormCloudModuleandFormModule, import only AlfrescoViewerModule to allow the usage of the AlfrescoViewerComponent into the file-viewer.widgetDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: