[ACS-4565] add search for categories tree in admin cc #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksanderSklorz
requested review from
TomikaArome,
nikita-web-ua,
jatin2008,
rbahirsheth,
arohilaGL and
MichalKinas
AleksanderSklorz
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
MichalKinas
reviewed
Feb 16, 2023
| @@ -13,11 +13,12 @@ Datasource service for category tree. | |||
|
|
|||
| ### Methods | |||
|
|
|||
| - **getSubNodes**(parentNodeId: `string`, skipCount?: `number`, maxItems?: `number`): [`Observable`](http://reactivex.io/documentation/observable.html)`<`[`TreeResponse<CategoryNode>`](../../../lib/content-services/src/lib/tree/models/tree-response.interface.ts)`>`<br/> | |||
| - **getSubNodes**(parentNodeId: `string`, skipCount?: `number`, maxItems?: `number`, name?: `string`): [`Observable`](http://reactivex.io/documentation/observable.html)`<`[`TreeResponse<CategoryNode>`](../../../lib/content-services/src/lib/tree/models/tree-response.interface.ts)`>`<br/> | |||
There was a problem hiding this comment.
Do we want to display search results as a tree?
There was a problem hiding this comment.
it does not display it as tree in reality. Please check PR for applications, there is screenshot. It is tree with 0 level so in reality it will be always flat list. I did not see sense to use separated component just to render flat list if I can have tree list with 0 level which is still flat list :)
lib/content-services/src/lib/category/services/category-tree-datasource.service.spec.ts
Outdated
Show resolved
Hide resolved
nikita-web-ua
approved these changes
Feb 16, 2023
pr-triage
bot
added
PR: partially-approved
PR: unreviewed
and removed
PR: unreviewed
PR: partially-approved
labels
AleksanderSklorz
force-pushed
the
ACS-4565-Add-search-for-categories-tree-in-admin-cc
branch
from
e6290be to
28ac7be
Compare
MichalKinas
approved these changes
Feb 16, 2023
lib/content-services/src/lib/category/services/category.service.spec.ts
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: partially-approved
PR: unreviewed
and removed
PR: unreviewed
PR: partially-approved
labels
AleksanderSklorz
force-pushed
the
ACS-4565-Add-search-for-categories-tree-in-admin-cc
branch
from
bf103da to
53ef4c9
Compare
DenysVuika
approved these changes
Feb 20, 2023
DenysVuika
deleted the
ACS-4565-Add-search-for-categories-tree-in-admin-cc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-4565
What is the new behaviour?
Added function which allows for categories searching.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Alfresco applications PR: https://github.com/Alfresco/alfresco-applications/pull/31