Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-4654] Sign in button isn't centred as expected #8430

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[ACA-4654] Sign in button isn't centred as expected #8430

merged 1 commit into from
Mar 31, 2023

Conversation

nikita-web-ua
Copy link
Contributor

@nikita-web-ua nikita-web-ua commented Mar 30, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

'Sign in' text is not aligned properly in login button
Screenshot 2023-03-30 at 15 54 32

What is the new behaviour?

'Sign in' text is aligned properly in login button
Screenshot 2023-03-30 at 15 54 58

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACA-4654

@pr-triage pr-triage bot added the PR: draft label Mar 30, 2023
@nikita-web-ua nikita-web-ua marked this pull request as ready for review March 30, 2023 13:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nikita-web-ua nikita-web-ua merged commit fc3bd7e into develop Mar 31, 2023
@nikita-web-ua nikita-web-ua deleted the fix/dev-mmaliarchuk-ACA-4654-Sign-in-button-is-not-centred branch March 31, 2023 06:45
Qetikv pushed a commit that referenced this pull request Apr 3, 2023
@nikita-web-ua @Qetikv
[ACA-4654] style fix (#8430)
f6d0598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@MateuszHY MateuszHY MateuszHY approved these changes

@TomikaArome TomikaArome TomikaArome approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikita-web-ua @DenysVuika @TomikaArome @MateuszHY @AleksanderSklorz