Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5867] migrate date-range-filter.service.ts from moment to date-fns dependency #8832

Closed
wants to merge 1 commit into from

Conversation

jatin2008
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
moment dependency is being used in date-range-filter.service.ts

What is the new behaviour?
migrated date-range-filter.service.ts from moment to date-fns dependency

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [ x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jatin2008 jatin2008 marked this pull request as ready for review August 21, 2023 05:14
@jatin2008
Copy link
Contributor Author

Please refer to the PR- #8833 it includes migration of lib/process-services-cloud/src/lib/common/date-range-filter/date-range-filter.service.spec.ts & lib/process-services-cloud/src/lib/common/date-range-filter/date-range-filter.service.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants