Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5311] Notification History Bug Fix #9011

Merged
merged 13 commits into from
Nov 3, 2023
Merged

[ACS-5311] Notification History Bug Fix #9011

merged 13 commits into from
Nov 3, 2023

Conversation

SheenaMalhotra182
Copy link
Contributor

@SheenaMalhotra182 SheenaMalhotra182 commented Oct 19, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
If 'mark as all is pressed', the notifications restore upon reloading the page.

What is the new behaviour?
Added logic to maintain a 'read' flag in notification-history (local storage). Now

  1. the notifications menu will render only unread notifications and
  2. if 'mark as all is pressed', the notifications will clear from the menu and will not restore upon reloading the page.
notificationBugFix.mp4

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-5311
Once this PR is merged, ADW PR https://github.com/Alfresco/alfresco-applications/pull/412 needs to be merged to complete the fix

@SheenaMalhotra182 SheenaMalhotra182 force-pushed the ACS-5311-notification-history branch from 76cfdb2 to 21d366f Compare November 2, 2023 13:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit 94fb615 into develop Nov 3, 2023
33 checks passed
@DenysVuika DenysVuika deleted the ACS-5311-notification-history branch November 3, 2023 14:41
rbahirsheth added a commit that referenced this pull request Nov 17, 2023
@rbahirsheth
Revert "[ACS-5311] Notification History Bug Fix (#9011)"
d621b20 
This reverts commit 94fb615.
@rbahirsheth rbahirsheth mentioned this pull request Nov 17, 2023
Merged
DenysVuika pushed a commit that referenced this pull request Nov 17, 2023
@rbahirsheth
Revert "[ACS-5311] Notification History Bug Fix (#9011)" (#9096)
4af9451 
This reverts commit 94fb615.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@rbahirsheth rbahirsheth rbahirsheth approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@arohilaGL arohilaGL Awaiting requested review from arohilaGL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SheenaMalhotra182 @DenysVuika @rbahirsheth @AleksanderSklorz