[ADF-5562][ADF-5564]Removed !important from from and version list component #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohilaGL
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
VitoAlbano
approved these changes
Dec 8, 2023
VitoAlbano
force-pushed
the
dev-arohila-ADF-5562
branch
from
7303c35 to
712c1ef
Compare
DenysVuika
reviewed
Dec 11, 2023
| @@ -32,7 +32,7 @@ | |||
| } | |||
|
|
|||
| .app-form-config-editor { | |||
| height: 500px !important; | |||
| min-height: 500px; | |||
There was a problem hiding this comment.
min-height and height are different properties, and different purpose
There was a problem hiding this comment.
accommodated change with height property.
arohilaGL
force-pushed
the
dev-arohila-ADF-5562
branch
from
712c1ef to
8a3d5ba
Compare
| (onInit)="onInitFormEditor($event)"> | ||
| </ngx-monaco-editor> | ||
| <div class="app-form-config-editor"> | ||
| <ngx-monaco-editor style="height: 100%" id="adf-form-config-editor" [options]="editorOptions" |
There was a problem hiding this comment.
Can you add this style via a class, or using the id already mentioned here
#adf-form-config-editor {
height: 100%;
}
|
I'm also seeing a lot of formatting changes, especially in the .html file. Can you try to minimise them so as to ensure only the required changes are propagated forward |
AleksanderSklorz
approved these changes
Jan 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
!important is present in adf-aform and versino-list
What is the new behaviour?
!important removed from adf-form and version list
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: