Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-19542] Fix infinite loop when code flow is enabled #9193

Merged
merged 9 commits into from
Jan 23, 2024
Merged

[AAE-19542] Fix infinite loop when code flow is enabled #9193

merged 9 commits into from
Jan 23, 2024

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Dec 21, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
AAE-19542

What is the new behaviour?
The infinite loop on ADW APA is fixed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@alep85 alep85 changed the title [AAE-12531] Fix infinite loop with code flow [AAE-19542] Fix infinite loop with code flow Jan 15, 2024
@alep85 alep85 force-pushed the dev-alepore-AAE-12531 branch 5 times, most recently from 7c8b9eb to 0b813a2 Compare January 19, 2024 09:24
@alep85 alep85 marked this pull request as ready for review January 19, 2024 09:24
@alep85 alep85 changed the title [AAE-19542] Fix infinite loop with code flow [AAE-19542] Fix infinite loop with code flow enabled Jan 19, 2024
@alep85 alep85 changed the title [AAE-19542] Fix infinite loop with code flow enabled [AAE-19542] Fix infinite loop when code flow is enabled Jan 19, 2024
@alep85 alep85 force-pushed the dev-alepore-AAE-12531 branch from 0b813a2 to 7e89706 Compare January 23, 2024 08:41
@alep85 alep85 force-pushed the dev-alepore-AAE-12531 branch from 7e89706 to 4e2a39b Compare January 23, 2024 11:57
alep85 added 2 commits January 23, 2024 17:47
@alep85
Revert "[AAE-12531] Set angular-oauth-oidc version to 14, since versi…
a8842e8 
…on 15 doesn't work with angular v14"

This reverts commit 4e2a39b.
@alep85
Revert "[AAE-12531] Bump angular-oauth-oidc to version 15, fixed a lo…
8ad6a33 
…t of critical bugs and ready for angular 15"

This reverts commit 9ae308a.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alep85 alep85 merged commit 62bc842 into develop Jan 23, 2024
38 of 39 checks passed
@alep85 alep85 deleted the dev-alepore-AAE-12531 branch January 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoABastos DiogoABastos DiogoABastos approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@andrea-ligios andrea-ligios Awaiting requested review from andrea-ligios

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alep85 @DenysVuika @DiogoABastos