Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6212] Fix overlaping labels and incorrect color for warning #9219

Conversation

AleksanderSklorz
Copy link
Contributor

@AleksanderSklorz AleksanderSklorz commented Jan 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6212

What is the new behaviour?
Labels don't overlap with fields borders anymore and color for warning message for public link is correct now.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
ACA PR: Alfresco/alfresco-content-app#3589

@AleksanderSklorz AleksanderSklorz force-pushed the ACS-6212-Share-Action-popup-floating-labels-overlap-the-borders-and-message-info-text-in-red-colour branch from 2568a19 to 62ec7e1 Compare January 9, 2024 14:36
@AleksanderSklorz AleksanderSklorz force-pushed the ACS-6212-Share-Action-popup-floating-labels-overlap-the-borders-and-message-info-text-in-red-colour branch from 62ec7e1 to d85d53e Compare January 15, 2024 12:23
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AleksanderSklorz AleksanderSklorz merged commit b46d468 into develop Jan 18, 2024
33 checks passed
@AleksanderSklorz AleksanderSklorz deleted the ACS-6212-Share-Action-popup-floating-labels-overlap-the-borders-and-message-info-text-in-red-colour branch January 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants