[AAE-19610] Add specific date range settings to search filter #9250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiogoABastos
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
eromano
approved these changes
Jan 17, 2024
eromano
approved these changes
Jan 18, 2024
|
MichalKinas
reviewed
Jan 18, 2024
| this.combinedDisplayValue = this.combinedDisplayValue ? `${this.combinedDisplayValue} ${displayLabelForField}` : `${displayLabelForField}`; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| private getDisplayLabelForField(fieldForDisplayLabel: string): string { | ||
| return this.settings && this.settings.displayedLabelsByField && this.settings.displayedLabelsByField[fieldForDisplayLabel] ? this.settings.displayedLabelsByField[fieldForDisplayLabel] : fieldForDisplayLabel; |
There was a problem hiding this comment.
Can be way shorter like: return this.settings?.displayedLabelsByField?.[fieldForDisplayLabel] ?? fieldForDisplayLabel;
| } | ||
|
|
||
| private setDefaultDateFormatSettings() { | ||
| if (this.settings && !this.settings.dateFormat) { |
There was a problem hiding this comment.
Suggested change
| if (this.settings && !this.settings.dateFormat) { | |
| if (!this.settings?.dateFormat) { |
| export class TabLabelsPipe implements PipeTransform { | ||
|
|
||
| transform(field: string, settings?: SearchWidgetSettings): string { | ||
| return settings && settings.displayedLabelsByField && settings.displayedLabelsByField[field] ? settings.displayedLabelsByField[field] : field; |
There was a problem hiding this comment.
Can be way shorter like: return this.settings?.displayedLabelsByField?.[field] ?? field;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Search filter was missing important settings for
date-rangetypeWhat is the new behaviour?
Important settings for
date-rangetype were introduced to fix this bug:https://alfresco.atlassian.net/browse/AAE-19610
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: