Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-24151] - ADW: Users can see some actions Edit Offline" and "Upload New Version" for the declared record #9295

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

  1. Extensions can't extend exsiting rules, they can only replace them. It's problem, when 2 extensions want to specify their own rules for the same element.
  2. 'Recent files' page doesn't have access to 'aspects' of nodes and because of that not all visibility rules can be applied.

What is the new behaviour?

  1. If rule is passed in array form, it would be merged and all the rules will be applied.
  2. 'Recent files' page has access to 'aspects' of nodes.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland force-pushed the MNT-24151-regression-of-fixed-behaviour-adw-users-can-see-some-actions-edit-offline-and-upload-new-version-for-the-declared-record branch 2 times, most recently from e268f5b to 9f30c8e Compare February 2, 2024 08:00
@dominikiwanekhyland dominikiwanekhyland force-pushed the MNT-24151-regression-of-fixed-behaviour-adw-users-can-see-some-actions-edit-offline-and-upload-new-version-for-the-declared-record branch from 9f30c8e to 4aa0a51 Compare February 7, 2024 10:34
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DenysVuika DenysVuika merged commit 7238df1 into develop Feb 7, 2024
33 checks passed
@DenysVuika DenysVuika deleted the MNT-24151-regression-of-fixed-behaviour-adw-users-can-see-some-actions-edit-offline-and-upload-new-version-for-the-declared-record branch February 7, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants