AAE-19762 Fix login redirect #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiogoABastos
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
alep85
reviewed
Feb 8, 2024
| @@ -58,6 +58,7 @@ export class AuthConfigService { | |||
| ...oauth2, | |||
| oidc: oauth2.implicitFlow || oauth2.codeFlow || false, | |||
| issuer: oauth2.host, | |||
| nonceStateSeparator: '~', | |||
There was a problem hiding this comment.
Please test this change running hxp and apa apps linking this branch
There was a problem hiding this comment.
Tested in both HxP and APA
andrea-ligios
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Currently there is no way for a user to be redirect to a specific page after login (happening only in HxP)
What is the new behaviour?
Users are now redirected to a specific page after login
NonceStateSeparatorwas using default value ";" which is not supported by the AWS API GatewayDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: