Create a new widget for decimal type #9335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
BSekula
force-pushed
the
dev-bsekula-AAE-19481-decimal-widget
branch
2 times, most recently
from
bedd4af to
870b7ee
Compare
DudaRobert
requested changes
Feb 15, 2024
| expect(decimalValidator.validate(field)).toBeTrue(); | ||
| }); | ||
|
|
||
| it('should return true when value has smaller precission', () => { |
There was a problem hiding this comment.
Suggested change
| it('should return true when value has smaller precission', () => { | |
| it('should return true when value is of lower precision', () => { |
lib/core/src/lib/form/components/widgets/core/form-field-validator.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/form/components/widgets/core/form-field-validator.spec.ts
Outdated
Show resolved
Hide resolved
| expect(decimalValidator.validate(field)).toBeFalse(); | ||
| }); | ||
|
|
||
| it('should return true, when value is negative number and has correct precission', () => { |
There was a problem hiding this comment.
Suggested change
| it('should return true, when value is negative number and has correct precission', () => { | |
| it('should return false, when value is a negative number and of correct precission', () => { |
There was a problem hiding this comment.
copy/paste issue .. fixed 👍
lib/core/src/lib/form/components/widgets/core/form-field-validator.spec.ts
Outdated
Show resolved
Hide resolved
DudaRobert
approved these changes
Feb 15, 2024
BSekula
force-pushed
the
dev-bsekula-AAE-19481-decimal-widget
branch
from
6ebf349 to
9d17327
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: