Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HXCS-2818] - fix issues with ERROR RangeError: Invalid time value #9340

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
There are errors in the console when opening the details tab for record files in ADW and they are not rendered correctly. Errors:
core.mjs:7626 ERROR RangeError: Invalid time value
at lightFormat (index.js:80:11)
at DateFnsUtils.forceLocal (adf-core.mjs:1846:36)
at CardViewDateItemModel.prepareDate (adf-core.mjs:16821:52)
at get displayValue (adf-core.mjs:16812:43)
at adf-content-services.mjs:19853:89
at Array.filter ()
at ContentMetadataComponent.showGroup (adf-content-services.mjs:19853:45)
at ContentMetadataComponent_ng_container_5_div_1_Template (adf-content-services.mjs:19986:13666)
at executeTemplate (core.mjs:12108:9)
at refreshView (core.mjs:11971:13)
at toDate (index.js:48:20)
at lightFormat (index.js:78:28)
at DateFnsUtils.forceLocal (adf-core.mjs:1846:36)
at CardViewDateItemModel.prepareDate (adf-core.mjs:16821:52)
at get displayValue (adf-core.mjs:16812:43)
at adf-content-services.mjs:19853:89
at Array.filter ()
at ContentMetadataComponent.showGroup (adf-content-services.mjs:19853:45)
at ContentMetadataComponent_ng_container_5_div_1_Template (adf-content-services.mjs:19986:13666)
at executeTemplate (core.mjs:12108:9)

What is the new behaviour?
Details tab is rendered correctly and there are no errors in the console.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland force-pushed the HXCS-2818-when-i-set-in-workspace-just-date-for-the-date-property-also-time-is-set-fix branch from 9fbfb3e to 90b43da Compare February 16, 2024 07:15
@dominikiwanekhyland dominikiwanekhyland force-pushed the HXCS-2818-when-i-set-in-workspace-just-date-for-the-date-property-also-time-is-set-fix branch from 90b43da to 18bf5d7 Compare February 16, 2024 08:48
@dominikiwanekhyland dominikiwanekhyland force-pushed the HXCS-2818-when-i-set-in-workspace-just-date-for-the-date-property-also-time-is-set-fix branch from 18bf5d7 to 20b314a Compare February 16, 2024 08:48
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dominikiwanekhyland dominikiwanekhyland merged commit 40d64d2 into develop Feb 16, 2024
33 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the HXCS-2818-when-i-set-in-workspace-just-date-for-the-date-property-also-time-is-set-fix branch February 16, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants